From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@gmail.com>
Subject: Re: [PATCH 1/4] gnu: openmpi: Add memchecker support
Date: Sat, 17 May 2014 19:09:38 -0500
Message-ID: <87vbt4q75p.fsf@gmail.com>
References: <878uq17xvk.fsf@gmail.com> <87ppjc4rzs.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43120)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1Wlocq-0003KI-7Y
	for guix-devel@gnu.org; Sat, 17 May 2014 20:06:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1Wlock-0005WA-G1
	for guix-devel@gnu.org; Sat, 17 May 2014 20:06:48 -0400
In-reply-to: <87ppjc4rzs.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org


Ludovic Courtès writes:

> Eric Bavier <ericbavier@gmail.com> skribis:
>
>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Sat, 17 May 2014 00:02:44 -0500
>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>
>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>   [arguments]: Add configure flags for memchecker.
>
> [...]
>
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)))
>>      (propagated-inputs
>> -     `(("gfortran" ,gfortran-4.8)))
>> +     `(("gfortran" ,gfortran-4.8)
>> +       ("valgrind" ,valgrind)))
>
> Why is Valgrind propagated?  I would expect it to be used only in
> OpenMPI’s test suite, no?

The intention of OpenMPI's memchecker option is to allow one to more
easily use valgrind when executing mpi programs.  That being said, it is
an optional feature, so it may not need to be propagated.  I'll look at
that again.

>
> (I also wonder why GFortran is propagated, probably overlooked it
> before.)

GFortran needs to be propagated for the OpenMPI compiler wrappers.

-- 
Eric Bavier