all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Bavier <ericbavier@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/4] gnu: openmpi: Add memchecker support
Date: Sat, 17 May 2014 19:09:38 -0500	[thread overview]
Message-ID: <87vbt4q75p.fsf@gmail.com> (raw)
In-Reply-To: <87ppjc4rzs.fsf@gnu.org>


Ludovic Courtès writes:

> Eric Bavier <ericbavier@gmail.com> skribis:
>
>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Sat, 17 May 2014 00:02:44 -0500
>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>
>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>   [arguments]: Add configure flags for memchecker.
>
> [...]
>
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)))
>>      (propagated-inputs
>> -     `(("gfortran" ,gfortran-4.8)))
>> +     `(("gfortran" ,gfortran-4.8)
>> +       ("valgrind" ,valgrind)))
>
> Why is Valgrind propagated?  I would expect it to be used only in
> OpenMPI’s test suite, no?

The intention of OpenMPI's memchecker option is to allow one to more
easily use valgrind when executing mpi programs.  That being said, it is
an optional feature, so it may not need to be propagated.  I'll look at
that again.

>
> (I also wonder why GFortran is propagated, probably overlooked it
> before.)

GFortran needs to be propagated for the OpenMPI compiler wrappers.

-- 
Eric Bavier

  reply	other threads:[~2014-05-18  0:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-17  5:55 [PATCH 1/4] gnu: openmpi: Add memchecker support Eric Bavier
2014-05-17 10:30 ` Ludovic Courtès
2014-05-18  0:09   ` Eric Bavier [this message]
2014-05-18 10:06     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbt4q75p.fsf@gmail.com \
    --to=ericbavier@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.