From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: Add minetest-data.
Date: Sat, 06 Sep 2014 23:18:46 +0200
Message-ID: <87vbp0qwg9.fsf@gnu.org>
References: <1410028023-16046-1-git-send-email-dthompson2@worcester.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XQNNn-0001vV-Kt
	for guix-devel@gnu.org; Sat, 06 Sep 2014 17:19:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XQNNg-0001rR-SL
	for guix-devel@gnu.org; Sat, 06 Sep 2014 17:18:55 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:32914)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XQNNg-0001rJ-IH
	for guix-devel@gnu.org; Sat, 06 Sep 2014 17:18:48 -0400
In-Reply-To: <1410028023-16046-1-git-send-email-dthompson2@worcester.edu>
	(David Thompson's message of "Sat, 6 Sep 2014 14:27:02 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

Hi!

Some style comments:

David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/games.scm (minetest-data): New variable.
>         (method url-fetch)
>         (uri (string-append "http://www.hyperrealm.com/" name "/"
> -                           name  "-" version  ".tar.gz"))=20
> +                           name  "-" version  ".tar.gz"))
>         (sha256
>          (base32 "19nc5vq4bnkjvhk8srqddzhcs93jyvpm9r6lzjzwc1mgf08yg0a6"))=
))

Looks like some whitespace cleanup, which should rather be in a separate pa=
tch.

>      (build-system gnu-build-system)
> @@ -235,7 +237,7 @@ level's exit.  The game is presented in a 2D side vie=
w.")
>  into stereotyped or otherwise humorous dialects.  The filters are provid=
ed as
>  a C library, so they can easily be integrated into other programs.")
>      (license gpl2+)))
> -=20
> +
>  (define-public cmatrix
>    (package
>      (name "cmatrix")
> @@ -305,11 +307,11 @@ interface or via an external visual interface such =
as GNU XBoard.")
>      (build-system gnu-build-system)
>      (arguments
>       '(#:phases
> -       (alist-cons-before=20
> +       (alist-cons-before
>          'configure 'pre-conf
>          ;; This is GNU.  So use gnuchess as the first choice of engine
>          (lambda _
> -          (substitute* "xboard.conf.in"=20
> +          (substitute* "xboard.conf.in"

Ditto.

> +    (native-inputs
> +     `(("source" ,source)
> +       ("tar" ,tar)
> +       ("gzip" ,(@ (gnu packages compression) gzip))
> +       ("coreutils" ,coreutils)))

Remove coreutils.

> +    (arguments
> +     `(#:modules ((guix build utils))
> +       #:builder (begin
> +                   (use-modules (guix build utils))
> +                   (let ((tar (string-append (assoc-ref %build-inputs "t=
ar")
> +                                             "/bin/tar"))
> +                         (cp (string-append (assoc-ref %build-inputs
> +                                                       "coreutils")
> +                                            "/bin/cp"))

Remove =E2=80=98cp=E2=80=99.

> +                         (path (string-append (assoc-ref %build-inputs
> +                                                         "gzip")
> +                                              "/bin")))
> +                     (setenv "PATH" path)
> +                     (system* tar "xvf" (assoc-ref %build-inputs "source=
"))
> +                     (chdir (string-append "minetest_game-" ,version))
> +                     (mkdir-p install-dir)
> +                     (system* cp "-r" "." install-dir)))))

Use =E2=80=98copy-recursively=E2=80=99 instead.

Thanks,
Ludo=E2=80=99.