* [PATCH] gnu: Add xdotool.
@ 2014-12-14 10:48 John Darrington
2014-12-14 15:14 ` Alex Kost
0 siblings, 1 reply; 3+ messages in thread
From: John Darrington @ 2014-12-14 10:48 UTC (permalink / raw)
To: guix-devel; +Cc: John Darrington
* gnu/packages/xdisorg.scm (xdotool): New variable.
---
gnu/packages/xdisorg.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 6820d01..1c29330 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -29,6 +29,7 @@
#:use-module (gnu packages image)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages glib)
+ #:use-module (gnu packages perl)
#:use-module (gnu packages xorg))
;; packages outside the x.org system proper
@@ -57,6 +58,47 @@ can also be used for copying files, as an alternative to sftp/scp, thus
avoiding password prompts when X11 forwarding has already been setup.")
(license license:gpl2+)))
+(define-public xdotool
+ (package
+ (name "xdotool")
+ (version "2.20110530.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://semicomplete.googlecode.com/files/" name "-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0rxggg1cy7nnkwidx8x2w3c5f3pk6dh2b6q0q7hp069r3n5jrd77"))))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:tests? #f ; Test suite requires a lot of black magic
+ #:phases
+ (alist-replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys #:rest args)
+ (setenv "PREFIX" (assoc-ref outputs "out"))
+ (setenv "LDFLAGS" (string-append "-Wl,-rpath="
+ (assoc-ref %outputs "out") "/lib"))
+
+ (setenv "CC" "gcc"))
+ %standard-phases)))
+ (native-inputs `(("perl" ,perl))) ; for pod2man
+ (inputs `(("libx11" ,libx11)
+ ("libxext" ,libxext)
+ ("libxi" ,libxi)
+ ("libxinerama" ,libxinerama)
+ ("libxtst" ,libxtst)))
+ (home-page "http://www.semicomplete.com/projects/xdotool")
+ (synopsis "Fake keyboard/mouse input, window management, and more")
+ (description "Xdotool lets you simulate keyboard input and mouse activity,
+move and resize windows, etc. It does this using X11's XTEST extension and
+other Xlib functions. Additionally, you can search for windows and move,
+resize, hide, and modify window properties like the title. If your window
+manager supports it, you can use xdotool to switch desktops, move windows
+between desktops, and change the number of desktops.")
+ (license license:bsd-3)))
+
(define-public xeyes
(package
(name "xeyes")
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gnu: Add xdotool.
2014-12-14 10:48 [PATCH] gnu: Add xdotool John Darrington
@ 2014-12-14 15:14 ` Alex Kost
2014-12-14 16:38 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Alex Kost @ 2014-12-14 15:14 UTC (permalink / raw)
To: John Darrington; +Cc: guix-devel
I've tried this patch and it has been built successfully on my i686 machine.
So only nitpickings from me.
John Darrington (2014-12-14 13:48 +0300) wrote:
[...]
> + (arguments
> + '(#:tests? #f ; Test suite requires a lot of black magic
> + #:phases
Trailing space ↑
> + (alist-replace 'configure
Another one ↑
> + (lambda* (#:key outputs #:allow-other-keys #:rest args)
> + (setenv "PREFIX" (assoc-ref outputs "out"))
> + (setenv "LDFLAGS" (string-append "-Wl,-rpath="
Double space ↑↑
> + (assoc-ref %outputs "out") "/lib"))
Not aligned properly and this line is too long ↑
> +
> + (setenv "CC" "gcc"))
> + %standard-phases)))
> + (native-inputs `(("perl" ,perl))) ; for pod2man
> + (inputs `(("libx11" ,libx11)
> + ("libxext" ,libxext)
> + ("libxi" ,libxi)
> + ("libxinerama" ,libxinerama)
> + ("libxtst" ,libxtst)))
> + (home-page "http://www.semicomplete.com/projects/xdotool")
> + (synopsis "Fake keyboard/mouse input, window management, and more")
> + (description "Xdotool lets you simulate keyboard input and mouse activity,
> +move and resize windows, etc. It does this using X11's XTEST extension and
Single space ↑
> +other Xlib functions. Additionally, you can search for windows and move,
> +resize, hide, and modify window properties like the title. If your window
Single space ↑
> +manager supports it, you can use xdotool to switch desktops, move windows
> +between desktops, and change the number of desktops.")
> + (license license:bsd-3)))
IIUC using double spaces in the end of sentences is a convention. Also
I noticed that you make descriptions look like this:
(description "…")
This makes the first line significantly shorter than other ones, so some
people (including me) prefer the following variant:
(description
"…")
What about making a convention on how "description" fields should look.
Ludo?
--
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gnu: Add xdotool.
2014-12-14 15:14 ` Alex Kost
@ 2014-12-14 16:38 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2014-12-14 16:38 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel, John Darrington
Alex Kost <alezost@gmail.com> skribis:
> IIUC using double spaces in the end of sentences is a convention.
Indeed. ‘guix lint’ should catch it.
> Also I noticed that you make descriptions look like this:
>
> (description "…")
>
> This makes the first line significantly shorter than other ones, so some
> people (including me) prefer the following variant:
>
> (description
> "…")
>
> What about making a convention on how "description" fields should look.
> Ludo?
I prefer the latter as well, but I don’t usually insist on that.
We don’t have specific written conventions; there’s .dir-locals.el, and
then a reference to a more general coding convention for Scheme in
‘HACKING’. Would it help to have them written down?
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-14 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-14 10:48 [PATCH] gnu: Add xdotool John Darrington
2014-12-14 15:14 ` Alex Kost
2014-12-14 16:38 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.