From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomas Cech <sleep_walker@suse.cz>
Subject: Re: [PATCH v4] gnu: Add bullet.
Date: Mon, 15 Dec 2014 11:48:31 +0100
Message-ID: <87vbld9ojk.wl-sleep_walker@suse.cz>
References: <87vblhynx2.fsf@netris.org>
	<1418474497-6119-1-git-send-email-sleep_walker@suse.cz>
	<1418474497-6119-2-git-send-email-sleep_walker@suse.cz>
	<877fxvfsnf.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcech@suse.de>) id 1Y0TCi-0003JN-Ha
	for guix-devel@gnu.org; Mon, 15 Dec 2014 05:48:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcech@suse.de>) id 1Y0TCc-0007e3-FP
	for guix-devel@gnu.org; Mon, 15 Dec 2014 05:48:40 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49383 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcech@suse.de>) id 1Y0TCc-0007dq-90
	for guix-devel@gnu.org; Mon, 15 Dec 2014 05:48:34 -0500
In-Reply-To: <877fxvfsnf.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

At Sat, 13 Dec 2014 10:58:44 -0500,
David Thompson wrote:
>=20
> Tom=E1=B9 =C8ech <sleep_walker@suse.cz> writes:
> > ...
> > @@ -0,0 +1,13 @@
> > +diff -up bullet-2.82-r2704/CMakeLists.txt.orig bullet-2.82-r2704/CMake=
Lists.txt
> > +--- bullet-2.82-r2704/CMakeLists.txt.orig	2014-12-13 00:09:49.64871018=
0 +0100
> > ++++ bullet-2.82-r2704/CMakeLists.txt	2014-12-13 00:10:44.205708986 +01=
00
> > +@@ -17,6 +17,9 @@ IF (NOT CMAKE_BUILD_TYPE)
> > +  SET(CMAKE_BUILD_TYPE "Release")
> > + ENDIF (NOT CMAKE_BUILD_TYPE)=20
> > +=20
> > ++SET(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -fPIC")
> > ++SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
> > ++
>=20
> Is the second 'SET' redundant?

Yes, it is wrong.

> Rather than using this patch file, you should instead add a new build
> phase to the bullet package.  Add something like this to the arguments
> field, after '#:tests? #f':
>=20
>   #:phases (alist-cons-before
>             'configure 'set-env-vars
>             (lambda _
>               (setenv "CMAKE_CXX_FLAGS"
>                       (string-append (getenv "CMAKE_C_FLAGS")
>             "-fPIC"))))

I liked that idea and used that approach. Updated patch is following...

Thanks for your review and patience.

Best regards,

S_W