From: Tomas Cech <sleep_walker@suse.cz>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v4] gnu: Add bullet.
Date: Mon, 15 Dec 2014 11:48:31 +0100 [thread overview]
Message-ID: <87vbld9ojk.wl-sleep_walker@suse.cz> (raw)
In-Reply-To: <877fxvfsnf.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
At Sat, 13 Dec 2014 10:58:44 -0500,
David Thompson wrote:
>
> Tomáš Čech <sleep_walker@suse.cz> writes:
> > ...
> > @@ -0,0 +1,13 @@
> > +diff -up bullet-2.82-r2704/CMakeLists.txt.orig bullet-2.82-r2704/CMakeLists.txt
> > +--- bullet-2.82-r2704/CMakeLists.txt.orig 2014-12-13 00:09:49.648710180 +0100
> > ++++ bullet-2.82-r2704/CMakeLists.txt 2014-12-13 00:10:44.205708986 +0100
> > +@@ -17,6 +17,9 @@ IF (NOT CMAKE_BUILD_TYPE)
> > + SET(CMAKE_BUILD_TYPE "Release")
> > + ENDIF (NOT CMAKE_BUILD_TYPE)
> > +
> > ++SET(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -fPIC")
> > ++SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
> > ++
>
> Is the second 'SET' redundant?
Yes, it is wrong.
> Rather than using this patch file, you should instead add a new build
> phase to the bullet package. Add something like this to the arguments
> field, after '#:tests? #f':
>
> #:phases (alist-cons-before
> 'configure 'set-env-vars
> (lambda _
> (setenv "CMAKE_CXX_FLAGS"
> (string-append (getenv "CMAKE_C_FLAGS")
> "-fPIC"))))
I liked that idea and used that approach. Updated patch is following...
Thanks for your review and patience.
Best regards,
S_W
next prev parent reply other threads:[~2014-12-15 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:21 [PATCH v3] gnu: Add bullet Tomáš Čech
2014-12-12 3:09 ` David Thompson
2014-12-12 7:08 ` Tomas Cech
2014-12-12 13:53 ` Mark H Weaver
2014-12-13 12:41 ` Tomáš Čech
2014-12-13 12:41 ` [PATCH v4] " Tomáš Čech
2014-12-13 15:58 ` David Thompson
2014-12-15 10:48 ` Tomas Cech [this message]
2014-12-15 10:50 ` [PATCH v5] " Tomáš Čech
2014-12-15 13:14 ` [PATCH v4] " David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbld9ojk.wl-sleep_walker@suse.cz \
--to=sleep_walker@suse.cz \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.