From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH]: jack: propagate libuuid Date: Tue, 17 Feb 2015 17:13:04 -0500 Message-ID: <87vbj06vbj.fsf@netris.org> References: <87vbj0kxm1.fsf@mango.localdomain> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNqO1-0007WW-P2 for guix-devel@gnu.org; Tue, 17 Feb 2015 17:12:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNqNz-0007dU-2r for guix-devel@gnu.org; Tue, 17 Feb 2015 17:12:57 -0500 Received: from world.peace.net ([50.252.239.5]:54349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNqNy-0007cg-UP for guix-devel@gnu.org; Tue, 17 Feb 2015 17:12:54 -0500 In-Reply-To: <87vbj0kxm1.fsf@mango.localdomain> (Ricardo Wurmus's message of "Tue, 17 Feb 2015 22:59:50 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: Guix-devel Ricardo Wurmus writes: > Attached is a patch to move libuuid (provided by "util-linux") from the > regular inputs of jack-1 to the propagated-inputs, as uuid.h is included > from the JACK headers. > > The patch also removes "util-linux" from those inputs depending on > jack-1. I recompiled all of them and they still built as expected. > > ~~ Ricardo > > From 4729906c5156a7aeec917cbe1408d08a47369d59 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 17 Feb 2015 09:45:16 +0100 > Subject: [PATCH] gnu: jack: propagate input "util-linux" > > * gnu/packages/audio.scm (jack-1): Move input "util-linux" to > `propagated-inputs'. > * gnu/packages/audio.scm (aubio, ardour, azr3, lash, patchage): Remove > "util-linux" from `inputs'. Can you please split this up into two commits? The first commit should just move 'util-linux' into jack-1's propagated-inputs (with a comment added in the source code explaining why its needed), and the second commit should remove 'util-linux' from the inputs of the packages that use jack-1. Okay to push with these changes. Thanks! Mark