From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/9] gnu: Add geoclue service.
Date: Wed, 08 Apr 2015 14:50:07 +0200
Message-ID: <87vbh6wzr4.fsf@gnu.org>
References: <1428413322.661898.18272@badger>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YfpQr-0003Kc-Px
	for guix-devel@gnu.org; Wed, 08 Apr 2015 08:50:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YfpQo-0007Qw-Df
	for guix-devel@gnu.org; Wed, 08 Apr 2015 08:50:13 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50511)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YfpQo-0007Qr-AP
	for guix-devel@gnu.org; Wed, 08 Apr 2015 08:50:10 -0400
In-Reply-To: <1428413322.661898.18272@badger> (Andy Wingo's message of "Tue, 7
	Apr 2015 10:26:25 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andy Wingo <wingo@pobox.com>
Cc: guix-devel@gnu.org

Andy Wingo <wingo@pobox.com> skribis:

> * gnu/services/geoclue.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add geoclue service.

LGTM, but...

> +(define* (geoclue-service #:key (geoclue geoclue)
> +                          (whitelist '())
> +                          (wifi-geolocation-url
> +                           ;; Mozilla geolocation service:
> +                           "https://location.services.mozilla.com/v1/geo=
locate?key=3Dgeoclue")
> +                          (submit-data? #f)
> +                          (wifi-submission-url
> +                           "https://location.services.mozilla.com/v1/sub=
mit?key=3Dgeoclue")
> +                          (submission-nick "geoclue")
> +                          (applications %standard-geoclue-applications))
> +  "Return a service that runs the @command{geoclue}, location service."

... could you expound on the docstring, and then add it to guix.texi
like I did for colord?  Specifically, the docstring should mention all
the parameters and their meaning, possibly pointing to the upstream doc
for more details.

(I would do that, but since I=E2=80=99m geoclue-less [haha!] I=E2=80=99d ra=
ther let you
handle it.)

Thanks!

Ludo=E2=80=99.