From: ludo@gnu.org (Ludovic Courtès)
To: Andy Wingo <wingo@pobox.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/9] gnu: Add geoclue service.
Date: Wed, 08 Apr 2015 14:50:07 +0200 [thread overview]
Message-ID: <87vbh6wzr4.fsf@gnu.org> (raw)
In-Reply-To: <1428413322.661898.18272@badger> (Andy Wingo's message of "Tue, 7 Apr 2015 10:26:25 +0200")
Andy Wingo <wingo@pobox.com> skribis:
> * gnu/services/geoclue.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add geoclue service.
LGTM, but...
> +(define* (geoclue-service #:key (geoclue geoclue)
> + (whitelist '())
> + (wifi-geolocation-url
> + ;; Mozilla geolocation service:
> + "https://location.services.mozilla.com/v1/geolocate?key=geoclue")
> + (submit-data? #f)
> + (wifi-submission-url
> + "https://location.services.mozilla.com/v1/submit?key=geoclue")
> + (submission-nick "geoclue")
> + (applications %standard-geoclue-applications))
> + "Return a service that runs the @command{geoclue}, location service."
... could you expound on the docstring, and then add it to guix.texi
like I did for colord? Specifically, the docstring should mention all
the parameters and their meaning, possibly pointing to the upstream doc
for more details.
(I would do that, but since I’m geoclue-less [haha!] I’d rather let you
handle it.)
Thanks!
Ludo’.
prev parent reply other threads:[~2015-04-08 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 8:26 [PATCH 4/9] gnu: Add geoclue service Andy Wingo
2015-04-08 12:50 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbh6wzr4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.