From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Allan Webber <cwebber@dustycloud.org>
Subject: Re: [PATCH] Add guile-emacs!
Date: Thu, 14 May 2015 10:53:43 -0500
Message-ID: <87vbfvdugp.fsf@earlgrey.lan>
References: <87r3qo5idm.fsf@earlgrey.lan> <873830f2m0.fsf@earlgrey.lan>
	<87wq0bh70o.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1YsvTi-0002P8-Ao
	for guix-devel@gnu.org; Thu, 14 May 2015 11:55:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1YsvTf-0005ln-5J
	for guix-devel@gnu.org; Thu, 14 May 2015 11:55:18 -0400
Received: from dustycloud.org ([50.116.34.160]:48191)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1YsvTf-0005lj-1k
	for guix-devel@gnu.org; Thu, 14 May 2015 11:55:15 -0400
In-reply-to: <87wq0bh70o.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich Kammer <taylanbayirli@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Taylan Ulrich Kammer writes:

> Christopher Allan Webber <cwebber@dustycloud.org> writes:
>
>> Okay, how about a version of guile-emacs that works and incorporates
>> feedback from this thread?  Yeah?  Anyone?
>>
>> Whoooooooooo guile-emacs! :)
>
> Yay! :-)
>
> I would have thought these would go to guile.scm and emacs.scm.  What do
> others think?

It can be done... since guile-for-guile-emacs doesn't make sense without
guile-emacs (probably), I thought maybe bundling them together makes
sense...

>> +(define-public guile-for-guile-emacs
>> [...]
>> +    (inputs
>> +     `(("gettext" ,gnu-gettext)
>
> Sure it shouldn't be in native-inputs?  I'm guessing autogen uses it.

So, could someone describe the difference between inputs and
native-inputs?  The manual provides no clarity!  I never know where it
goes and why... I just mime what other packages are doing.

>> +(define-public guile-emacs
>> [...]
>> +     (substitute-keyword-arguments `(#:parallel-build? #f         
>
> A comment explaining why parallel builds are disabled would be good.

Good idea.

>> +                                     ;; Tests aren't passing for now.
>> +                                     ;; Obviously we should re-enable this!
>> +                                     #:tests? #f
>
> Tests should generally always be enabled so the second line of the
> comment would be redundant; just a nitpick. :-)

Yes, but this time especially!  I think it'll be a good sign for
guile-emacs when we can tear off the test disabling... :)

>
> Otherwise looks good to me.  Thanks!
>
> Taylan