From: Mathieu Lirzin <mthl@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: ratpoison: Clean definition.
Date: Tue, 25 Aug 2015 23:54:46 +0200 [thread overview]
Message-ID: <87vbc3rq3d.fsf@openmailbox.org> (raw)
In-Reply-To: <87wpwsk179.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 18 Aug 2015 18:31:38 +0200")
ludo@gnu.org (Ludovic Courtès) writes:
> Mathieu Lirzin <mthl@openmailbox.org> skribis:
>
>> * gnu/packages/ratpoison.scm (ratpoison)[arguments]: Use modify-phases.
>> [inputs]: Sort alist. Move ratpoison.desktop to ...
^^^
>> [source]: Fix indentation.
>> [native-inputs]: Likewise. ... here.
>
> It’s OK to not mention trivial reindentation here. Otherwise LGTM,
> thanks!
Done in 45fed6d32c288dbf5400ace42179256036c4c233 with "Sort alphabetically."
instead of "Sort alist." because the field 'inputs' is not a proper alist.
--
Mathieu Lirzin
prev parent reply other threads:[~2015-08-25 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 16:59 [PATCH 0/2] Ratpoison update and cleanup Mathieu Lirzin
2015-08-06 16:59 ` [PATCH 1/2] gnu: ratpoison: Update to 1.4.8 Mathieu Lirzin
2015-08-08 18:50 ` Mark H Weaver
2015-08-06 16:59 ` [PATCH 2/2] gnu: ratpoison: Clean definition Mathieu Lirzin
2015-08-18 16:31 ` Ludovic Courtès
2015-08-25 21:54 ` Mathieu Lirzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbc3rq3d.fsf@openmailbox.org \
--to=mthl@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.