From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: [PATCH] emacs: Improve file names of generated graphs.
Date: Fri, 16 Oct 2015 19:58:10 +0300 [thread overview]
Message-ID: <87vba6ycm5.fsf_-_@gmail.com> (raw)
In-Reply-To: <8737xbw7nd.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 16 Oct 2015 10:16:06 +0200")
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
Ludovic Courtès (2015-10-16 11:16 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
[...]
>> +@item guix-dot-file-name-function
>> +Function used to define a name of the generated graph file. Default
>> +name is @file{/tmp/graph-XXXXXX.png}.
>
> Not related to this patch either, but we might consider changing the
> template to /tmp/guix-el-graph-XXXX.png for clarity.
Indeed! I don't like "el" part though, what about "guix-emacs-graph-"
instead? (as in the attached patch)
[-- Attachment #2: 0001-emacs-Improve-file-names-of-generated-graphs.patch --]
[-- Type: text/x-patch, Size: 1103 bytes --]
From 6dd1084f14723484028df86c04e7c997538fc951 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Fri, 16 Oct 2015 17:27:58 +0300
Subject: [PATCH] emacs: Improve file names of generated graphs.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Suggested by Ludovic Courtès <ludo@gnu.org>.
* emacs/guix-external.el (guix-png-file-name): Change prefix of a file
name to "guix-emacs-graph-" to avoid possible conflicts.
---
emacs/guix-external.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/guix-external.el b/emacs/guix-external.el
index d233473..580676e 100644
--- a/emacs/guix-external.el
+++ b/emacs/guix-external.el
@@ -64,7 +64,7 @@ If ARGS is nil, use `guix-dot-default-arguments'."
"Return '.png' file name in the `temporary-file-directory'."
(concat (make-temp-name
(concat (file-name-as-directory temporary-file-directory)
- "graph-"))
+ "guix-emacs-graph-"))
".png"))
(provide 'guix-external)
--
2.5.0
next prev parent reply other threads:[~2015-10-16 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 19:46 [PATCH] emacs: Add "View graph" actions to system graph commands Alex Kost
2015-10-16 8:16 ` Ludovic Courtès
2015-10-16 16:57 ` [PATCH] doc: emacs: Document "View graph" popup action Alex Kost
2015-10-17 13:23 ` Ludovic Courtès
2015-10-16 16:58 ` Alex Kost [this message]
2015-10-17 13:23 ` [PATCH] emacs: Improve file names of generated graphs Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vba6ycm5.fsf_-_@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.