From: ludo@gnu.org (Ludovic Courtès)
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] build-system/haskell: CONFIG_SHELL env variable.
Date: Sun, 25 Oct 2015 22:58:23 +0100 [thread overview]
Message-ID: <87vb9uipa8.fsf@gnu.org> (raw)
In-Reply-To: <1445621842-17735-1-git-send-email-paul@denknerd.org> (Paul van der Walt's message of "Fri, 23 Oct 2015 19:37:22 +0200")
Paul van der Walt <paul@denknerd.org> skribis:
> For Cabal packages with "build-type: Configure", a configure shell
> script is run to set up build parameters. These scripts need the
> CONFIG_SHELL environment variable to be set to function properly.
>
> * guix/build/haskell-build-system.scm (configure): Set CONFIG_SHELL if
> necessary.
LGTM.
> A previous commit to the haskell-build-system made sure that if
> necessary, the CONFIG_SHELL environment variable is set. That obviates
> the individual patches applied to some packages. Remove them.
>
> * gnu/packages/haskell.scm (ghc-network): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-old-time): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-sdl-image): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-sdl-mixer): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-sdl): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-unix-time): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-x11): Remove CONFIG_SHELL patch.
Please use the shorter style, and mention the “syntactical” change:
* gnu/packages/haskell.scm (ghc-network, ghc-old-time,
ghc-sdl-image)[arguments]: Remove 'fix-/bin/sh’ phase.
Apart from this, LGTM.
Thanks!
Ludo’.
next prev parent reply other threads:[~2015-10-25 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 17:37 [PATCH] build-system/haskell: CONFIG_SHELL env variable Paul van der Walt
2015-10-23 18:04 ` [PATCH] gnu: haskell: Remove CONFIG_SHELL patches Paul van der Walt
2015-10-25 21:58 ` Ludovic Courtès [this message]
2015-10-26 9:18 ` [PATCH] build-system/haskell: CONFIG_SHELL env variable Paul van der Walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb9uipa8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=paul@denknerd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.