From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] build: Fix out-of-tree building of documentation.
Date: Sat, 09 Jan 2016 22:30:57 +0100
Message-ID: <87vb72784u.fsf@gnu.org>
References: <87fuy6ydmj.fsf@T420.taylan>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aI16H-0005hx-3Q
	for guix-devel@gnu.org; Sat, 09 Jan 2016 16:31:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aI16C-0004mm-IU
	for guix-devel@gnu.org; Sat, 09 Jan 2016 16:31:05 -0500
In-Reply-To: <87fuy6ydmj.fsf@T420.taylan> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Sat, 09 Jan 2016 16:30:12 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> From 41650754511487f5f1f937317eebd80c19ca8bf1 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Sat, 9 Jan 2016 15:56:23 +0100
> Subject: [PATCH] build: Fix out-of-tree building of documentation.
>
> * doc.am (.dot.png, .dot.pdf, .dot.eps, .png.eps): Create the directory
>   for each target in case of out-of-tree building.

The files in $(DOT_VECTOR_GRAPHICS) are part of the distribution.  Thus,
when building from a tarball, they are in $(srcdir), not in $(builddir).

However, when building from Git out-of-tree, they should go do $(srcdir)
as well (as is done for Info files.)

A fix would be:


--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

diff --git a/doc.am b/doc.am
index e3a91cc..21b08be 100644
--- a/doc.am
+++ b/doc.am
@@ -1,5 +1,5 @@
 # GNU Guix --- Functional package management for GNU
-# Copyright =C2=A9 2012, 2013, 2014, 2015 Ludovic Court=C3=A8s <ludo@gnu.o=
rg>
+# Copyright =C2=A9 2012, 2013, 2014, 2015, 2016 Ludovic Court=C3=A8s <ludo=
@gnu.org>
 # Copyright =C2=A9 2013 Andreas Enge <andreas@enge.fr>
 #
 # This file is part of GNU Guix.
@@ -66,15 +66,15 @@ DOT_OPTIONS =3D					\
=20
 .dot.png:
 	$(DOT) -Tpng $(DOT_OPTIONS) < "$<" > "$@.tmp"
-	mv "$@.tmp" "$@"
+	mv "$@.tmp" "$(srcdir)/$@"
=20
 .dot.pdf:
 	$(DOT) -Tpdf $(DOT_OPTIONS) < "$<" > "$@.tmp"
-	mv "$@.tmp" "$@"
+	mv "$@.tmp" "$(srcdir)/$@"
=20
 .dot.eps:
 	$(DOT) -Teps $(DOT_OPTIONS) < "$<" > "$@.tmp"
-	mv "$@.tmp" "$@"
+	mv "$@.tmp" "$(srcdir)/$@"
=20
 .png.eps:
 	convert "$<" "$@-tmp.eps"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Does it work for you?

Ludo=E2=80=99.

--=-=-=--