From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: gnu: Add python-wtforms.
Date: Sat, 13 Feb 2016 15:07:17 -0800 [thread overview]
Message-ID: <87vb5stdju.fsf@dustycloud.org> (raw)
In-Reply-To: <87wpq8te06.fsf@dustycloud.org>
Christopher Allan Webber writes:
> Leo Famulari writes:
>
>> On Sat, Feb 13, 2016 at 01:55:01PM -0800, Christopher Allan Webber wrote:
>>> Christopher Allan Webber writes:
>>
>> [...]
>>
>>> >>> * gnu/packages/python.scm (python-wtforms, python2-wtforms): New variables.
>>> >>
>>> >> It looks good to me, but I wonder if the python-3 variant really needs
>>> >> setuptools? If so, okay. If not, can you use the new python2-variant
>>> >> system [0] to provide setuptools for python2-wtforms?
>>> >>
>>> >> [0] Introduced in 48b311b1b3ba
>>> >
>>> > Okay, I'll give that a try, and will make an adjustment if appropriate,
>>> > and regardless, push after figuring that out.
>>> >
>>> > Thanks to both of you!
>>>
>>> Well, I think it's significant enough of a change where I should get
>>> some validation that everything looks right before I push. New version,
>>> ahoy! Is it ok?
>>
>> I believe that you still must call 'package-with-python2' in the
>> python-2 variant, and the argument to that should be
>> (strip-python2-variant python-foo).
>>
>> I've attached an example commit that seems to work, from one of my WIP
>> branches.
>
> Ah, you're right! New patch!
>
> - Chris
Leo also pointed out that the (name) redefinition might not be needed,
and indeed it wasn't!
And with that, pushed. Whew!
next prev parent reply other threads:[~2016-02-13 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 19:43 gnu: Add python-wtforms Christopher Allan Webber
2016-02-12 21:52 ` Thompson, David
2016-02-12 23:42 ` Christopher Allan Webber
2016-02-12 23:57 ` Leo Famulari
2016-02-13 21:55 ` Christopher Allan Webber
2016-02-13 22:23 ` Leo Famulari
2016-02-13 22:57 ` Christopher Allan Webber
2016-02-13 23:07 ` Christopher Allan Webber [this message]
2016-02-12 22:02 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb5stdju.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.