From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH v2] gnu: Add python-psycopg2, python2-psycopg2
Date: Wed, 24 Feb 2016 16:05:43 -0800 [thread overview]
Message-ID: <87vb5dr6wx.fsf@dustycloud.org> (raw)
In-Reply-To: <20160224233918.3d70dd72@scratchpost.org>
This looks pretty good. And happily, I've tested with MediaGoblin, and
it works! Horray! A few things...
Danny Milosavljevic writes:
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 55a62a9..e1dbc31 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -17,6 +17,7 @@
Could you use `git format-patch` to generate this patch instead?
Probably `git format-patch HEAD...origin/master` will work. You can
look at the commit log to see the desired format, or read the Change Log
section of the GNU coding standards:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html
> ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
> ;;; Copyright © 2015 Chris Marusich <cmmarusich@gmail.com>
> +;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -8156,3 +8157,34 @@ introspection of @code{zope.interface} instances in code.")
>
> (define-public python2-sphinx-repoze-autointerface
> (package-with-python2 python-sphinx-repoze-autointerface))
> +
> +(define-public python-psycopg2
> + (package
> + (name "python-psycopg2")
> + (version "2.6.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "psycopg2" version))
> + (sha256
> + (base32
> + "0k4hshvrwsh8yagydyxgmd0pjm29lwdxkngcq9fzfzkmpsxrmkva"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f)) ; TODO re-enable after providing a test-db.
> + ; Tests would require a postgresql database "psycopg2_test"
> + ; and a running postgresql database management service.
; comments comment a line, to the right of the line, so the #:tests?
line has it right. However, the other ones should use two comments.
It might even be nicer if it goes to the right, like:
(arguments
;; Tests would require a postgresql database "psycopg2_test"
;; and a running postgresql database management service.
`(#:tests? #f)) ; TODO re-enable after providing a test-db.
or:
(arguments
`(;; Tests would require a postgresql database "psycopg2_test"
;; and a running postgresql database management service.
#:tests? #f)) ; TODO re-enable after providing a test-db.
> + (inputs
> + `(("postgresql" ,postgresql))) ; libpq
> + (home-page "http://initd.org/psycopg/")
> + (synopsis "Python PostgreSQL adapter")
> + (description
> + "psycopg2 is a thread-safe PostgreSQL adapter that implements DB-API 2.0.")
> + (license lgpl3+)
> + (properties `((python2-variant . ,(delay python2-psycopg2))))))
> +
> +(define-public python2-psycopg2
> + (package
> + (inherit (package-with-python2
> + (strip-python2-variant python-psycopg2)))
> + (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
next prev parent reply other threads:[~2016-02-25 0:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 11:01 [PATCH] gnu: Add python-psycopg2, python2-psycopg2 Danny Milosavljevic
2016-02-19 21:22 ` Leo Famulari
2016-02-22 0:39 ` Danny Milosavljevic
2016-02-22 2:38 ` Christopher Allan Webber
2016-02-24 22:39 ` [PATCH v2] " Danny Milosavljevic
2016-02-25 0:05 ` Christopher Allan Webber [this message]
2016-02-25 0:52 ` [PATCH v3] " Danny Milosavljevic
2016-02-25 17:53 ` Christopher Allan Webber
2016-02-25 19:30 ` Leo Famulari
2016-02-25 21:28 ` Christopher Allan Webber
2016-02-25 21:35 ` Leo Famulari
2016-02-25 22:22 ` Danny Milosavljevic
2016-02-25 22:45 ` Christopher Allan Webber
2016-02-25 23:13 ` Leo Famulari
2016-02-25 23:52 ` Christopher Allan Webber
2016-02-22 2:39 ` [PATCH] " Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb5dr6wx.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.