From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add gtklick. Date: Sat, 27 Feb 2016 10:17:46 +0100 Message-ID: <87vb5aeclh.fsf@elephly.net> References: <87a8moeylu.fsf@elephly.net> <87r3fzxct2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZb0g-00072S-Tu for guix-devel@gnu.org; Sat, 27 Feb 2016 04:17:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZb0f-0003mL-Ri for guix-devel@gnu.org; Sat, 27 Feb 2016 04:17:58 -0500 In-reply-to: <87r3fzxct2.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> From 76cb9cb91b76f4bb723030d3d5a63238cdf98e20 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Thu, 25 Feb 2016 09:45:05 +0100 >> Subject: [PATCH 1/3] gnu: Add pyliblo. >> >> * gnu/packages/audio.scm (python-pyliblo, python2-pyliblo): New >> variables. > > [...] > >> + (home-page "http://das.nasophon.de/pyliblo/") >> + (synopsis "Python bindings for the liblo OSC library") > > Maybe just “Python bindings for liblo”, and… > >> + (description >> + "Pyliblo is a Python wrapper for the liblo OSC library. It supports > > “… for the liblo Open Sound Control (OSC) library.” Okay. >> From 1dc15ad2e3776904ff8b838add00d66d9671b48a Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Fri, 26 Feb 2016 08:05:40 +0100 >> Subject: [PATCH 2/3] gnu: python2-pygtk: Add libglade to inputs. >> >> * gnu/packages/gtk.scm (python2-pygtk)[inputs]: Add "libglade". > > OK. > >> From cfda70fdd6448980df9ba4c22894198366a2846d Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Thu, 25 Feb 2016 09:46:01 +0100 >> Subject: [PATCH 3/3] gnu: Add gtklick. >> >> * gnu/packages/music.scm (gtklick): New variable. > > [...] > >> + (modify-phases %standard-phases >> + (add-before 'build 'add-sitedirs >> + ;; .pth files are not automatically interpreted unless the >> + ;; directories containing them are added as "sites". The directories >> + ;; are then added to those in the PYTHONPATH. This is required for >> + ;; the operation of pygtk. > > Strangely, other users of pygtk don’t do that, no? What’s special here? Some do (and I don’t know why). I lifted this phase from “solfege”, which also won’t run without this. >> + (lambda _ >> + (substitute* "gtklick/gtklick.py" >> + (("import pygtk") >> + "import pygtk, site, sys >> +for path in [path for path in sys.path if 'site-packages' in path]: site.addsitedir(path)")))) > > I guess it’s a list comprehension, but I’m a bit confused by the syntax > and the various ‘path’. Oh well. :-) The Scheme equivalent is something like this: (for-each site.addsitedir (filter (cut string-contains <> "site-packages") sys.path)) The bracketed expression in Python is like the ‘(filter ...)’ expression. I don’t know if this could be expressed any clearer in plain Python without making this much longer. ~~ Ricardo