From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Wingo <wingo@igalia.com>
Subject: Re: [PATCH v4 1/9] gnu: cross: Use CROSS_*_INCLUDE_PATH for system
	headers.
Date: Mon, 25 Apr 2016 12:38:51 +0200
Message-ID: <87vb36x9ac.fsf@igalia.com>
References: <87vb492l7s.fsf@drakenvlieg.flower> <877fgio11v.fsf@elephly.net>
	<87r3eq2y2s.fsf@drakenvlieg.flower> <8760w2nzl4.fsf@elephly.net>
	<87d1q8lb7j.fsf@drakenvlieg.flower> <87k2k99l7w.fsf@gnu.org>
	<87d1pssnwl.fsf@drakenvlieg.flower> <871t614pk6.fsf@gnu.org>
	<87bn4yhurl.fsf_-_@drakenvlieg.flower>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1audvU-0000gp-V9
	for guix-devel@gnu.org; Mon, 25 Apr 2016 06:39:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1audvR-00081A-QX
	for guix-devel@gnu.org; Mon, 25 Apr 2016 06:39:36 -0400
In-Reply-To: <87bn4yhurl.fsf_-_@drakenvlieg.flower> (Jan Nieuwenhuizen's
	message of "Sun, 24 Apr 2016 23:40:03 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

On Sun 24 Apr 2016 23:40, Jan Nieuwenhuizen <janneke@gnu.org> writes:

> +                    (setenv "CPP" (string-append gcc "/bin/cpp"))
> +                    (for-each (lambda (var)
> +                                (and-let* ((value (getenv var))
> +                                           (path (search-path-as-string->list
> +                                                  value))
> +                                           (native-path
                                               ^^

Bad indentation here; it should be indented like let*

> +                                            (list->search-path-as-string
> +                                             (remove cross? path) ":"))))
> +                                (let* ((path (search-path-as-string->list
> +                                              (getenv var)))

However given this, both "value" and "path" should succeed without
error...

> +                                       (native-path
> +                                        (and path
> +                                             (list->search-path-as-string
> +                                              (remove cross? path) ":"))))

And this is a repeat?  Perhaps you meant to replace the and-let* block,
or to remove this one?  I would lean towards not using and-let* fwiw :)

> +                                  (if native-path (setenv var native-path))))

For one-armed ifs, please use "when" or "unless".  Tx :)

Andy