Ludovic Courtès writes:

> It fails to build here:
>
> starting phase `check'
> make: *** No rule to make target 'check'.  Stop.
> phase `check' failed after 0.0 seconds

Here also.  Weird.  Added

     `(#:test-target "test"

>> +    (license gpl2)))
>
> Version 2 only?

Yes, double checked.

> Could you send an updated patch?

Sure, find attached.

>> * gnu/system/linux-initrd.scm (base-initrd): Add nvme to linux-modules.
>
> Applied!

Thanks!

>> From 37ab729322b21acd325b43c97b47c8e217635cd1 Mon Sep 17 00:00:00 2001
>> From: Jan Nieuwenhuizen <janneke@gnu.org>
>> Date: Fri, 17 Jun 2016 13:45:28 +0200
>> Subject: [PATCH 3/4] nix: Allow ~ in store names.
>>
>> * nix/libstore/store-api.cc (checkStoreName): Add ~ to validChars.
>
> Nack!  :-)  This looks like a can of worms, so I’d rather change the GRUB
> version name.

Fine! :-)

>>      (name "grub")
>> -    (version "2.00")
>> +    (version "2.02~beta3")
>
> Could you make it “2.02beta3”?

Okay...

>>      (source (origin
>>               (method url-fetch)
>> -             (uri (string-append "mirror://gnu/grub/grub-"
>> -                                 version ".tar.xz"))
>> +             (uri (string-append
>> +                   "ftp://alpha.gnu.org/gnu/grub/grub-"
>> +                   version ".tar.xz"))

> Likewise, add a ‘file-name’ here to avoid “~”.

Ah, that's what I've been missing.  Thanks!

>>      (arguments
>>       '(#:configure-flags '("--disable-werror")
>> +       #:tests? #f ;; fail
>
> That’s cheating.  :-)
>
> Could you explain why/how it fails?  I would rather address it or at
> least make sure we have a good understanding of what’s going on.

Added

+     '(;; two warnings: suggest braces, signed/unsigned comparison
+       #:configure-flags '("--disable-werror")

these seem harmless...

and this one test

+                     ;; fails
+                     (substitute* "tests/grub_func_test.in"
+                       (("set -e") "exit 77\nset -e")))))))

fails, I haven't looked into whether it's a new test or what it does or
why it may fail.

Greetings,
Jan