From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 1/2] gnu: testdisk: Add optional dependencies.
Date: Tue, 05 Jul 2016 09:25:41 +0200
Message-ID: <87vb0kr1g8.fsf@elephly.net>
References: <20160703162555.19342-1-rekado@elephly.net>
	<20160703202223.GB26140@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bKKkL-0003zf-HI
	for guix-devel@gnu.org; Tue, 05 Jul 2016 03:26:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bKKkH-0007TW-Fg
	for guix-devel@gnu.org; Tue, 05 Jul 2016 03:26:17 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24560)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bKKkH-0007TM-6z
	for guix-devel@gnu.org; Tue, 05 Jul 2016 03:26:13 -0400
In-reply-to: <20160703202223.GB26140@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari <leo@famulari.name> writes:

> On Sun, Jul 03, 2016 at 06:25:54PM +0200, Ricardo Wurmus wrote:
>> * gnu/packages/admin.scm (testdisk)[inputs]: Add ntfs-3g and libjpeg.
>> ---
>>  gnu/packages/admin.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
>> index 415a35a..2014ecb 100644
>> --- a/gnu/packages/admin.scm
>> +++ b/gnu/packages/admin.scm
>> @@ -1149,9 +1149,11 @@ characters can be replaced as well, as can UTF-8 characters.")
>>                  "0v1jap83f5h99zv01v3qmqm160d36n4ysi0gyq7xzb3mqgmw75x5"))))
>>      (build-system gnu-build-system)
>>      (inputs
>> -     `(;; ("ntfs" ,ntfs)
>> +     `(("ntfs-3g" ,ntfs-3g)
>>         ("util-linux" ,util-linux)
>>         ("openssl" ,openssl)
>> +       ;; FIXME: add reiserfs
>> +       ("libjpeg" ,libjpeg)
>
> It already includes libjpeg ...

Ah, I’m sorry.

>>         ("zlib" ,zlib)
>>         ("e2fsprogs" ,e2fsprogs)
>>         ("libjpeg" ,libjpeg)
>
> ... here ;)
>
> So it should add ntfs-3g and the comment about reiserfs, right?

Yes.  Fixed and pushed.  Thanks!

~~ Ricardo