From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 03/13] gnu: pinentry-qt: Fix regression.
Date: Sun, 21 Aug 2016 16:16:40 -0400
Message-ID: <87vaytc1xz.fsf@netris.org>
References: <20160820215957.GA6502@jasmine>
	<20160821140825.13048-1-david@craven.ch>
	<20160821140825.13048-3-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZC2-0006BR-4y
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:18:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZBx-00075l-38
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:18:05 -0400
Received: from world.peace.net ([50.252.239.5]:41677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZBw-00075Z-Va
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:18:01 -0400
In-Reply-To: <20160821140825.13048-3-david@craven.ch> (David Craven's message
	of "Sun, 21 Aug 2016 16:08:16 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> writes:

> * gnu/packages/gnupg.scm (pinentry-qt)[native-inputs]: Add gnu-gettext.

The summary line should say "Add gnu-gettext to native-inputs" instead
of "Fix regression".

> ---
>  gnu/packages/gnupg.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
> index 7df96b4..fde6018 100644
> --- a/gnu/packages/gnupg.scm
> +++ b/gnu/packages/gnupg.scm
> @@ -28,6 +28,7 @@
>    #:use-module (gnu packages)
>    #:use-module (gnu packages adns)
>    #:use-module (gnu packages curl)
> +  #:use-module (gnu packages gettext)
>    #:use-module (gnu packages openldap)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pth)
> @@ -642,6 +643,8 @@ passphrase when @code{gpg} or @code{gpg2} is run and needs it.")))
>    (package
>      (inherit pinentry-tty)
>      (name "pinentry-qt")
> +    (native-inputs
> +     `(("gettext" ,gnu-gettext)))

It would be good to understand why this is needed, because it shouldn't
be needed for a tarball release.  Can you add a comment explaining the
reason, possibly with "FIXME" in it?

     Thanks,
       Mark