From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#20067: fix interpretation of grub configuration
Date: Sat, 10 Sep 2016 00:03:38 +0200
Message-ID: <87vay4rarp.fsf@gnu.org>
References: <20150309203443.GA3438@venom> <874mczk0an.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1biTtz-0001Xx-IF
	for bug-guix@gnu.org; Fri, 09 Sep 2016 18:04:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1biTty-0007jw-H0
	for bug-guix@gnu.org; Fri, 09 Sep 2016 18:04:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57241)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1biTty-0007jq-Do
	for bug-guix@gnu.org; Fri, 09 Sep 2016 18:04:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1biTty-0002io-7j
	for bug-guix@gnu.org; Fri, 09 Sep 2016 18:04:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.20067.B20067.147345863310444@debbugs.gnu.org>
In-Reply-To: <874mczk0an.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Tue, 23 Feb 2016 14:45:36 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 20067@debbugs.gnu.org

Good news!

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@suse.cz> skribis:
>
>> Grub configuration interpretes `linux' as directory where is located
>> bzImage. If I enter file name instead, result configuration will be
>> wrong.
>
> The solution will be to not automatically append =E2=80=9C/bzImage=E2=80=
=9D (and
> likewise for the initrd.)
>
> We could change places where =E2=80=98menu-entry=E2=80=99 is instantiated=
 to:
>
>   #~(string-append #$kernel "/bzImage")
>
> However, there=E2=80=99s the problem that the image name appears in the
> =E2=80=98parameters=E2=80=99 file of the system (as seen in the output of=
 =E2=80=98guix system
> build foo.scm=E2=80=99), where it is unevaluated.  If we use =E2=80=98str=
ing-append=E2=80=99 as
> above, a raw (string-append =E2=80=A6) sexp will appear in there, which i=
s not
> nice.
>
> To address this, an idea is to add =E2=80=9Cexpanders=E2=80=9D for gexps:=
 gexps already
> have =E2=80=9Ccompilers=E2=80=9D, and expanders would be similar except t=
hat they would
> produce something possibly different from just the derivation=E2=80=99s o=
utput
> file name.  For instance, we could write:
>
>   (file-append kernel "/bzImage")
>
> and that would expand directly to:
>
>   "/gnu/store/=E2=80=A6/bzImage"

AFAICS this is finally fixed!

  expanders in commit ebdfd776f4504c456d383ee8afa59fc6fdfc6756
  =E2=80=98file-append=E2=80=99 in commit a9e5e92f940381e3a4ee828c6d8ff22a7=
3067e17
  kernel file name in commit 44d5f54e31039d78f156bd9562dca293124eaa76

Please let me know how it goes!  In particular, does it work for the
dual-boot scenario you were interested in?

Thanks,
Ludo=E2=80=99.