From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 02/12] import: utils: Symbols from 'license->symbol' have a license: prefix. Date: Mon, 19 Sep 2016 22:06:43 +0900 Message-ID: <87vaxs82e4.fsf@gnu.org> References: <20160805183730.19049-2-david@craven.ch> <87k2f2ognn.fsf@elephly.net> <20160830140748.085c3492@openmailbox.org> <20160916000338.44cc4d03@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blyHf-0006jA-I9 for guix-devel@gnu.org; Mon, 19 Sep 2016 09:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blyHa-0006is-LA for guix-devel@gnu.org; Mon, 19 Sep 2016 09:06:55 -0400 In-Reply-To: (Eric Bavier's message of "Fri, 16 Sep 2016 12:02:43 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel Hello! Eric Bavier skribis: > My suggestion would be to move those procedures back into (guix import > pypi). I don't think they are as generic as their inclusion in (guix > import utils) might suggest. The strings they accept are specific to > pypi. I=E2=80=99m late, but I agree. Different repos (PyPI, CPAN, etc.) use diff= erent strings to denote licenses=E2=80=94similar but subtly different. So we sho= uld probably not try to factorize too much here. > Perhaps what might also be done is to clarify in the documentation > that the importers are not meant to be "dumpers": their output is not > intended to be dumped directly into package modules and pushed > upstream, and that editing will most likely need to take place. Maybe > adding a 'guix-import' command to guix.el could improve on this > situation in particular, by using geiser to detect proper symbol > prefixes, since it could have an understanding of what module the > imported package is destined for. Yeah. It already says that the output =E2=80=9Cis a package definition, or= a template thereof=E2=80=9D, which should be good enough, no? Thanks, Ludo=E2=80=99.