From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [Patch v2 1/3] gnu: Add python-pypdf2.
Date: Thu, 10 Nov 2016 11:46:24 +0100
Message-ID: <87vavvtxxb.fsf@gnu.org>
References: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com>
	<1478731153-27023-1-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c4msJ-0003kz-39
	for guix-devel@gnu.org; Thu, 10 Nov 2016 05:46:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c4msF-0000Am-82
	for guix-devel@gnu.org; Thu, 10 Nov 2016 05:46:31 -0500
In-Reply-To: <1478731153-27023-1-git-send-email-h.goebel@crazy-compilers.com>
	(Hartmut Goebel's message of "Wed, 9 Nov 2016 23:39:11 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/pdf.scm(python-pypdf2, python2-pypdf2): New variables.
                        ^
Space please.

> +    (arguments
> +     `(#:tests? #f)) ; tests fail in Python 3 (due to str vs bytes)

So probably we should only build the Python 2 variant?  WDYT?

> +@item and more!

I=E2=80=99d remove this line.

> +By being pure Python, it should run on any Python platform without any
> +dependencies on external libraries.  It can also work entirely on String=
IO

@code{StringIO}

Thanks,
Ludo=E2=80=99.