From: ludo@gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [Patch v2 1/3] gnu: Add python-pypdf2.
Date: Thu, 10 Nov 2016 11:46:24 +0100 [thread overview]
Message-ID: <87vavvtxxb.fsf@gnu.org> (raw)
In-Reply-To: <1478731153-27023-1-git-send-email-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Wed, 9 Nov 2016 23:39:11 +0100")
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * gnu/packages/pdf.scm(python-pypdf2, python2-pypdf2): New variables.
^
Space please.
> + (arguments
> + `(#:tests? #f)) ; tests fail in Python 3 (due to str vs bytes)
So probably we should only build the Python 2 variant? WDYT?
> +@item and more!
I’d remove this line.
> +By being pure Python, it should run on any Python platform without any
> +dependencies on external libraries. It can also work entirely on StringIO
@code{StringIO}
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-11-10 10:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 21:37 [PATCH 1/3] gnu: Add python-pypdf2 Hartmut Goebel
2016-11-08 21:37 ` [PATCH 2/3] gnu: Add python-pypdf Hartmut Goebel
2016-11-08 23:57 ` Leo Famulari
2016-11-09 22:04 ` Hartmut Goebel
2016-11-09 7:19 ` Efraim Flashner
2016-11-09 22:10 ` Hartmut Goebel
2016-11-08 21:37 ` [PATCH 3/3] gnu: Add pdfposter Hartmut Goebel
2016-11-09 0:02 ` Leo Famulari
2016-11-09 22:19 ` Hartmut Goebel
2016-11-08 23:55 ` [PATCH 1/3] gnu: Add python-pypdf2 Leo Famulari
2016-11-09 21:59 ` Hartmut Goebel
2016-11-09 22:39 ` [Patch v2 " Hartmut Goebel
2016-11-09 22:39 ` [Patch v2 2/3] gnu: Add python-pypdf Hartmut Goebel
2016-11-10 10:47 ` Ludovic Courtès
2016-11-09 22:39 ` [Patch v2 3/3] gnu: Add pdfposter Hartmut Goebel
2016-11-10 7:51 ` Efraim Flashner
2016-11-10 10:48 ` Ludovic Courtès
2016-11-10 13:28 ` Hartmut Goebel
2016-11-10 10:46 ` Ludovic Courtès [this message]
2016-11-10 10:58 ` [Patch v2 1/3] gnu: Add python-pypdf2 Hartmut Goebel
2016-11-10 12:35 ` Ludovic Courtès
2016-11-10 13:10 ` Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vavvtxxb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.