From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 09/18] gnu: Add r-wgcna. Date: Mon, 28 Nov 2016 22:45:59 +0100 Message-ID: <87vav71dns.fsf@elephly.net> References: <20161124165139.13740-1-rekado@elephly.net> <20161124165139.13740-10-rekado@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBTkb-0003QR-7x for guix-devel@gnu.org; Mon, 28 Nov 2016 16:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBTkY-0002Yn-3M for guix-devel@gnu.org; Mon, 28 Nov 2016 16:46:13 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBTkX-0002YG-RU for guix-devel@gnu.org; Mon, 28 Nov 2016 16:46:10 -0500 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org Ben Woodcroft writes: > On 25/11/16 02:51, Ricardo Wurmus wrote: >> [..] >> + (home-page >> + "http://www.genetics.ucla.edu/labs/horvath/CoexpressionNetwork/Rpackages/WGCNA/") > This line is a bit long, I don't remember, should it be split over two > lines? True, but I left it as it is. It’s just a tiny bit too long and we don’t usually split home-page strings, so I opted to keep it like this. >> + (synopsis "Weighted correlation network analysis") >> + (description >> + "This package provides functions necessary to perform Weighted >> +Correlation Network Analysis on high-dimensional data. It includes functions >> +for rudimentary data cleaning, construction of correlation networks, module >> +identification, summarization, and relating of variables and modules to sample > I found the 'and' a bit confusing. Maybe: > > It includes functions for rudimentary data cleaning, construction and > summarization of correlation networks, module identification and > functions for relating both variables and modules to sample traits. Thanks for the improved sentence. I’ve updated the description. >> +traits. It also includes a number of utility functions for data manipulation >> +and visualization.") >> + (license license:gpl2+))) >> + >> (define-public emboss >> (package >> (name "emboss") > LGTM, I have one just like it locally. > ben Cool, thanks for the review! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC http://elephly.net