* bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
[not found] ` <87h93csca5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
@ 2017-04-04 21:42 ` Ludovic Courtès
0 siblings, 0 replies; only message in thread
From: Ludovic Courtès @ 2017-04-04 21:42 UTC (permalink / raw)
To: Marius Bakke; +Cc: 25916-done, Kei Kebreau
Hello!
Marius Bakke <mbakke@fastmail.com> skribis:
> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Mar 01, 2017 at 12:20:41PM -0500, Kei Kebreau wrote:
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>> > Kei Kebreau <kei@openmailbox.org> writes:
>>> >
>>> >> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>>> >> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>>> >
>>> > Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
>>> > 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>>> >
>>> > d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>>> >
>>>
>>> Yay, what a useful patch!
>>>
>>> Aren't we pretty close to merging core-updates? If that's the case, I
>>> won't worry about pushing this to master.
>>
>> Someone should try checking if they can reproduce mumble on
>> core-updates, to make sure the backported GCC 7 patch is working
>> correctly :)
>
> That's a good test. Unfortunately, mumble fails to build on
> 'core-updates'.
It builds with current master (post ‘core-updates’ merge).
I’ve done a --check build and can confirm that our GCC now honors
‘SOURCE_DATE_EPOCH’, so the patch isn’t needed. \o/
Closing this bug!
Ludo’.
^ permalink raw reply [flat|nested] only message in thread