From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvWEE-0001Dk-Ht for guix-patches@gnu.org; Tue, 04 Apr 2017 17:43:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvWEA-00046W-7z for guix-patches@gnu.org; Tue, 04 Apr 2017 17:43:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34682) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvWEA-00046L-58 for guix-patches@gnu.org; Tue, 04 Apr 2017 17:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cvWE9-0003HB-UZ for guix-patches@gnu.org; Tue, 04 Apr 2017 17:43:01 -0400 Subject: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170301163530.17613-1-kei@openmailbox.org> <87wpc9ymkd.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87fuiwkj6e.fsf@openmailbox.org> <20170301214401.GA22137@jasmine> <87h93csca5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 04 Apr 2017 23:42:01 +0200 In-Reply-To: <87h93csca5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Thu, 02 Mar 2017 02:22:26 +0100") Message-ID: <87vaqjn93q.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 25916-done@debbugs.gnu.org, Kei Kebreau Hello! Marius Bakke skribis: > Leo Famulari writes: > >> On Wed, Mar 01, 2017 at 12:20:41PM -0500, Kei Kebreau wrote: >>> Marius Bakke writes: >>>=20 >>> > Kei Kebreau writes: >>> > >>> >> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' cal= ls >>> >> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp. >>> > >>> > Thanks a lot for this! The patch LGTM, but FYI won't be necessary once >>> > 'core-updates' is merged. See this commit, which backports a gcc7 pat= ch. >>> > >>> > d71d6fe85c4db778be6a2081cbbec6a3a494e4f9 >>> > >>>=20 >>> Yay, what a useful patch! >>>=20 >>> Aren't we pretty close to merging core-updates? If that's the case, I >>> won't worry about pushing this to master. >> >> Someone should try checking if they can reproduce mumble on >> core-updates, to make sure the backported GCC 7 patch is working >> correctly :) > > That's a good test. Unfortunately, mumble fails to build on > 'core-updates'. It builds with current master (post =E2=80=98core-updates=E2=80=99 merge). I=E2=80=99ve done a --check build and can confirm that our GCC now honors =E2=80=98SOURCE_DATE_EPOCH=E2=80=99, so the patch isn=E2=80=99t needed. \o/ Closing this bug! Ludo=E2=80=99.