all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
       [not found]       ` <87h93csca5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
@ 2017-04-04 21:42         ` Ludovic Courtès
  0 siblings, 0 replies; only message in thread
From: Ludovic Courtès @ 2017-04-04 21:42 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 25916-done, Kei Kebreau

Hello!

Marius Bakke <mbakke@fastmail.com> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Mar 01, 2017 at 12:20:41PM -0500, Kei Kebreau wrote:
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>> 
>>> > Kei Kebreau <kei@openmailbox.org> writes:
>>> >
>>> >> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>>> >> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>>> >
>>> > Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
>>> > 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>>> >
>>> > d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>>> >
>>> 
>>> Yay, what a useful patch!
>>> 
>>> Aren't we pretty close to merging core-updates? If that's the case, I
>>> won't worry about pushing this to master.
>>
>> Someone should try checking if they can reproduce mumble on
>> core-updates, to make sure the backported GCC 7 patch is working
>> correctly :)
>
> That's a good test. Unfortunately, mumble fails to build on
> 'core-updates'.

It builds with current master (post ‘core-updates’ merge).

I’ve done a --check build and can confirm that our GCC now honors
‘SOURCE_DATE_EPOCH’, so the patch isn’t needed.  \o/

Closing this bug!

Ludo’.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-04 21:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170301163530.17613-1-kei@openmailbox.org>
     [not found] ` <87wpc9ymkd.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
     [not found]   ` <87fuiwkj6e.fsf@openmailbox.org>
     [not found]     ` <20170301214401.GA22137@jasmine>
     [not found]       ` <87h93csca5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
2017-04-04 21:42         ` bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.