From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBd32-00021E-42
	for guix-patches@gnu.org; Fri, 19 May 2017 04:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBd2w-0007Ci-Fe
	for guix-patches@gnu.org; Fri, 19 May 2017 04:14:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51661)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dBd2w-0007CE-Bs
	for guix-patches@gnu.org; Fri, 19 May 2017 04:14:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBd2w-0007fp-3p
	for guix-patches@gnu.org; Fri, 19 May 2017 04:14:02 -0400
Subject: bug#26989: [PATCH] gnu: gjs: Update to 1.49.1.
Resent-Message-ID: <handler.26989.B26989.149518158229414@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170518215650.25400-1-kei@openmailbox.org>
Date: Fri, 19 May 2017 10:12:45 +0200
In-Reply-To: <20170518215650.25400-1-kei@openmailbox.org> (Kei Kebreau's
	message of "Thu, 18 May 2017 17:56:50 -0400")
Message-ID: <87vaoxi7sy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: 26989@debbugs.gnu.org

Hi Kei,

Kei Kebreau <kei@openmailbox.org> skribis:

> * gnu/packages/gnome.scm (gjs): Update to 1.49.1.
> [source]: Remove snippet.
> [arguments]: Replace check phase.
> [propagated-inputs]: Use mozjs-38 instead of mozjs-24; add cairo.

[...]

> -            ;; XXX: fails with:
> -            ;;   Failed to convert UTF-8 string to JS string: ...
> -            ;; TODO: actually fix it.
> -            (substitute* "installed-tests/js/testEverythingBasic.js"
> -              ((".*test_utf8_inout.*") ""))
> -            #t)))))
> +            #t))
> +         (replace 'check
> +           (lambda _
> +             ;; 17 test failures and 3 errors occur for unknown reasons.
> +             (system* "make" "-k" "check"))))))

Could you try to get more info about the test failures?

It would be good to determine whether these are genuine problems or
problems caused by our build environment.  Since gjs is quite central in
GNOME, AIUI, it would be best to have some confidence that it works
correctly.

Thanks,
Ludo=E2=80=99.