From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRzyR-00056W-8i for guix-patches@gnu.org; Mon, 03 Jul 2017 07:57:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRzyQ-0006NQ-94 for guix-patches@gnu.org; Mon, 03 Jul 2017 07:57:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRzyQ-0006NJ-6W for guix-patches@gnu.org; Mon, 03 Jul 2017 07:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRzyP-0007Gs-VX for guix-patches@gnu.org; Mon, 03 Jul 2017 07:57:01 -0400 Subject: [bug#27521] [PATCH] guix system: Add "--file-system-type" option. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <878tk6rmvo.fsf@gnu.org> <20170703103407.18974-1-dannym@scratchpost.org> Date: Mon, 03 Jul 2017 13:56:40 +0200 In-Reply-To: <20170703103407.18974-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Mon, 3 Jul 2017 12:34:07 +0200") Message-ID: <87van9pwcn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 27521@debbugs.gnu.org Danny Milosavljevic skribis: > * guix/scripts/system.scm (process-action): Pass file-system-type to ... > (perform-action): ... here. Add new keyword argument. Pass new value to= ... > (system-derivation-for-action): ... here. Add new keyword argument. > Pass new value to system-disk-image. > * doc/guix.texi (disk-image): Document new option. > --- > doc/guix.texi | 3 +++ > guix/scripts/system.scm | 23 +++++++++++++++++++---- > 2 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index d61a5b751..25354b8c9 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -16190,6 +16190,9 @@ in @var{file} that stands alone. By default, @co= mmand{guix system} > estimates the size of the image needed to store the system, but you can > use the @option{--image-size} option to specify a value. >=20=20 > +You can specify the root file system type by using the > +@option{--file-system-type} option. It defaults to "ext4". s/"ext4"/@code{ext4}/ You also need to add an @item for --file-system-type in the option table. Also, it might be good to add examples of other supported values, like: @cindex ISO-9660 format @cindex CD image format @cindex DVD image format @code{--file-system-type=3Diso9660} produces an ISO-9660 image, suitable for burning on CDs and DVDs. > + (option '(#\f "file-system-type") #t #f > + (lambda (opt name arg result) > + (alist-cons 'file-system-type arg > + result))) I=E2=80=99m not sure we want to use the =E2=80=9C-f=E2=80=9D shortcut here.= Initially I thought we=E2=80=99d have -f/--format for the image format, i.e., qcow2 vs. raw (are there any others?). Thoughts? Besides, I think =E2=80=9Cguix system disk-image --file-system-format=3Dfoo= barbaz=E2=80=9D fails badly, but I=E2=80=99m not sure how to fix it without having to maint= ain a list of valid file system names. Maybe we should just ignore this issue. Thoughts? Ludo=E2=80=99.