From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhiGv-0005xx-W9 for guix-patches@gnu.org; Tue, 15 Aug 2017 16:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhiGs-0005Ln-SH for guix-patches@gnu.org; Tue, 15 Aug 2017 16:17:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhiGs-0005LS-H2 for guix-patches@gnu.org; Tue, 15 Aug 2017 16:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhiGs-00038d-7I for guix-patches@gnu.org; Tue, 15 Aug 2017 16:17:02 -0400 Subject: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170815192136.GB9893@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> <20170815192136.GB9893@jasmine.lan> Date: Tue, 15 Aug 2017 22:15:38 +0200 Message-ID: <87valozixh.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari , Christopher Baines Cc: 28093@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote: >> On Mon, 14 Aug 2017 23:31:37 -0400 >> Leo Famulari wrote: >>=20 >> > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the >> > git@2.10 package with an origin reference of the source code. >> > (git@2.10): Remove variable. >>=20 >> It would be useful if outside of the changelog, but in the commit >> message, you could put why you are making the change. As far as I can >> tell, this won't change the cgit package, so I'm guessing the intent is >> to neaten up the code? > > Recently we started running the test suite of the "main" git package. > > That caused the build of this package to fail, which also made cgit > fail to build, and that was annoying. cgit was not affected by the failing git@2.10 package since it only uses the *source* derivation. It does not care about what's going on in git's [arguments]. :-) So this patch won't change anything from cgits perspective. I'm slightly in favor of keeping git@2.10 until it's really uneeded (awkward if we have to add it back later), but no strong opinion either way. I would probably have done this instead of disabling tests if I had thought about it. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmTVmoACgkQoqBt8qM6 VPriLQf8DICFhwc0zqmEUm3aTy6ua3vmaMj8uzDCdpYGyFxsdqiXww+qZjfCxZ81 0vmfr+kWHIRxGlm8G+Z9FhnsNBHAmqPVO6jNpaP05hQ9NBVSNvmabUON2tlLqyqk 9bGfEQPQWRBrHnTnuaXphLvCdNaa56F5kUcoajxATgb4FBvrZ8ZOBrmzU06aJm3U dIxwBugTkyW8LeOxkQitgyAaxkywCJJEqDH/N/codjGi9DbbN0dYJMYRcDEev/9Y +W6lic2WhUcTOKNvRDYm+uzrxbeg0x9BIKhvxZHFMLck3LUGxVKf9VDSrwthghUF 2SqRUuQKob58ctA+noIxVHg8zFk6kA== =mDuf -----END PGP SIGNATURE----- --=-=-=--