all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 28100@debbugs.gnu.org
Subject: [bug#28100] [PATCH 1/2] gnu: Add liblinebreak.
Date: Wed, 16 Aug 2017 11:03:57 +0200	[thread overview]
Message-ID: <87valnkhoi.fsf@elephly.net> (raw)
In-Reply-To: <20170815184709.18690-1-dannym@scratchpost.org>


Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/ebook.scm (liblinebreak): New variable.
> ---
>  gnu/packages/ebook.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index 32f4f3b2d..187d1ed63 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -195,3 +195,23 @@ ebooks for convenient reading.")
>                     license:public-domain
>                     license:silofl1.1
>                     license:cc-by-sa3.0))))
> +
> +(define-public liblinebreak
> +  (package
> +    (name "liblinebreak")
> +    (version "2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/vimgadgets"
> +                                  "/liblinebreak/" version
> +                                  "/liblinebreak-" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

this “file-name” field is not necessary.  The tarball is already
properly named.

> +              (sha256
> +               (base32
> +                "1f36dbq7nc77lln1by2n1yl050g9dc63viawhs3gc3169mavm36x"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://vimgadgets.sourceforge.net/liblinebreak/")
> +    (synopsis "Library for detecting where linebreaks are allowed in text")
> +    (description "@code{liblinebreak} is a library that can be used to detect
> +where linebreaks are allowed in a given text.")

“allowed” is a bit vague.  The description on the website is better, in
my opinion:

   Liblinebreak is an implementation of the line breaking algorithm as
   described in Unicode 6.0.0 Standard Annex 14, Revision 26. It breaks
   lines that contain Unicode characters. It is designed to be used in a
   generic text renderer.

Could you use that instead?

It’s good with these changes.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

      parent reply	other threads:[~2017-08-16  9:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 18:44 [bug#28100] [PATCH 0/2] Add FBReader Danny Milosavljevic
2017-08-15 18:47 ` [bug#28100] [PATCH 1/2] gnu: Add liblinebreak Danny Milosavljevic
2017-08-15 18:47   ` [bug#28100] [PATCH 2/2] gnu: Add fbreader Danny Milosavljevic
2017-08-16  9:00     ` Ricardo Wurmus
2017-08-16  9:03   ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87valnkhoi.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=28100@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.