From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkJGD-0007ES-Hm for guix-patches@gnu.org; Tue, 22 Aug 2017 20:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkJGA-0002aq-9J for guix-patches@gnu.org; Tue, 22 Aug 2017 20:11:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dkJGA-0002ag-5S for guix-patches@gnu.org; Tue, 22 Aug 2017 20:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dkJG9-0005RW-TP for guix-patches@gnu.org; Tue, 22 Aug 2017 20:11:01 -0400 Subject: [bug#27468] Acknowledgement ([PATCH] gnu: Add linkchecker.) Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <7a5dc060.AEQAMFHLF6MAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZTa-9@mailjet.com> <2307d2c7.AEQAMFHh1HMAAAAAAAAAAAPNQHwAAAACwQwAAAAAAAW9WABZTbIA@mailjet.com> Date: Wed, 23 Aug 2017 02:10:39 +0200 Message-ID: <87valf16v4.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac , 27468@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > This package seems to have fallen through the cracks. I just sent a new > patch made against the latest master. > >> This package has bundled dependencies -- dnspython and miniboa -- under >> "third_party/". They have been modified as described in >> third_party/dnspython/changelog.txt and >> third_party/miniboa-r42/CHANGES.txt respectively. Should I unbundle >> these dependencies? If so, how do I handle the fact that the bundled >> dependencies have been locally modified? > > I have raised the issue of unbundling with upstream. But, there has been > no response after 10 days. > > https://github.com/wummel/linkchecker/issues/729 > > I recommend we don't unbundle anything on our own, and let upstream do > their homework. WDYT? Sounds reasonable. Can you add this URL in a comment somewhere? LGTM apart from the cosmetic issues raised in the other message. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmcx/8ACgkQoqBt8qM6 VPoTTQf7Bb1HrrC2wi3k5mBUVWazEWcSlZl22BjWDUNSufuQYNbC0/Z6J7A2XOmP Nn1IxACHv11P5layqbbYeGKCSguyijIMnJNroIgbW/oK7KuXpb+fcSgIwOLsovDd KSFNOpPxSew6ED/uHIO6IIbKTKZvRzUhzF+99ngg9Z39CsKlMPZ++AAhLVBtmpe+ +4Xbmrzeg3P/w0YR9g+28xP5XufXGHbPlSUeSQ/qGK7dFyab922ljmp8Fn4eHiqM 64NKac1TvbWnoWhCfrFEfy1GHEd5Tfu4SVY3i+TBbPTR2X44We0AfutyDPPJbt2i 8LAKUhLKrPGNeofJhofBu67O27Rceg== =xTJe -----END PGP SIGNATURE----- --=-=-=--