all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 28145@debbugs.gnu.org
Subject: [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
Date: Tue, 29 Aug 2017 23:38:02 +0200	[thread overview]
Message-ID: <87val6qclh.fsf@gnu.org> (raw)
In-Reply-To: <20170829074902.1688b3c5@scratchpost.org> (Danny Milosavljevic's message of "Tue, 29 Aug 2017 07:49:02 +0200")

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi Ludo,
>
> On Tue, 22 Aug 2017 15:07:28 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>> 
>> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> > ISO-9660 superblock anymore.  
>> 
>> Why is it no longer needed?  Otherwise fine with me.  :-)
>
> Because we went ahead and now we just read it from the whole disk on boot (previously, it only accepted superblocks on partitions, remember?).
>
> Previously on master:
>
> - DVD
>   + ISO9660 superblock
>   + partition table
>     + partition
>       + ISO9660 superblock copy <--- GuixSD sees this
>
> Now on master:
>
> - DVD
>   + ISO9660 superblock <--- GuixSD sees this
>   + partition table
>     + partition
>       + ISO9660 superblock copy <--- what's this for now?
>
> With the patch:
>
> - DVD
>   + ISO9660 superblock <--- GuixSD sees this
>   + partition table
>     + partition

Thanks for the explanation, got it now.

Ludo’.

  reply	other threads:[~2017-08-29 21:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19  2:46 [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore Danny Milosavljevic
2017-08-22 13:07 ` Ludovic Courtès
2017-08-29  5:49   ` Danny Milosavljevic
2017-08-29 21:38     ` Ludovic Courtès [this message]
2017-09-19 21:29   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87val6qclh.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28145@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.