From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dnPNB-0003Hw-T9
	for guix-patches@gnu.org; Thu, 31 Aug 2017 09:19:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dnPN7-0001hp-VX
	for guix-patches@gnu.org; Thu, 31 Aug 2017 09:19:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56070)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dnPN7-0001hh-SF
	for guix-patches@gnu.org; Thu, 31 Aug 2017 09:19:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dnPN7-0000g8-JK
	for guix-patches@gnu.org; Thu, 31 Aug 2017 09:19:01 -0400
Subject: [bug#28273] [PATCH] gnu: Fix current-guix.
Resent-Message-ID: <handler.28273.B28273.15041855302585@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170829064930.19849-1-mail@cbaines.net>
Date: Thu, 31 Aug 2017 15:18:37 +0200
In-Reply-To: <20170829064930.19849-1-mail@cbaines.net> (Christopher Baines's
	message of "Tue, 29 Aug 2017 07:49:30 +0100")
Message-ID: <87val3ri36.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28273@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> Without this change, I get errors like:
>   ERROR: In procedure string-drop:
>   ERROR: Value out of range 0 to 35: 51
>
> * gnu/packages/package-management.scm (current-guix): Pass exactly the sa=
me
>   path to git-predicate and local-file, to ensure that the select? functi=
on is
>   compatible.

Good catch, LGTM.

I think that fundamentally, we should arrange for =E2=80=98git-predicate=E2=
=80=99 to not
do any string prefix comparison.  That=E2=80=99s bound to fail.  If we could
somehow restrict it to comparing inode numbers, that=E2=80=99d be perfect.

Ludo=E2=80=99.