From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56830)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1fHP-0004dm-26
	for guix-patches@gnu.org; Mon, 09 Oct 2017 17:08:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1fHO-0006so-9b
	for guix-patches@gnu.org; Mon, 09 Oct 2017 17:08:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50039)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e1fHO-0006sZ-68
	for guix-patches@gnu.org; Mon, 09 Oct 2017 17:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e1fHN-0000St-UV
	for guix-patches@gnu.org; Mon, 09 Oct 2017 17:08:01 -0400
Subject: [bug#28765] [PATCH] config: Conditionally configure daemon offload
	script.
Resent-Message-ID: <handler.28765.B28765.15075832431730@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <CY4PR11MB17189D487BEBC3AA8150097AB7740@CY4PR11MB1718.namprd11.prod.outlook.com>
Date: Mon, 09 Oct 2017 23:07:10 +0200
In-Reply-To: <CY4PR11MB17189D487BEBC3AA8150097AB7740@CY4PR11MB1718.namprd11.prod.outlook.com>
	(Eric Bavier's message of "Mon, 9 Oct 2017 19:08:21 +0000")
Message-ID: <87vajoowsh.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Eric Bavier <bavier@cray.com>
Cc: 28765@debbugs.gnu.org

Eric Bavier <bavier@cray.com> skribis:

> From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@cray.com>
> Date: Mon, 9 Oct 2017 13:58:04 -0500
> Subject: [PATCH] config: Conditionally configure daemon offload script.
                   ^
Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things build-rel=
ated.

> * config-daemon.ac (nix/scripts/offload): Configure only if offloading en=
abled.

It LGTM, but is it helpful?  guix-daemon does not invoke =E2=80=98guix offl=
oad=E2=80=99
when it=E2=80=99s missing, as can be seen in guix-daemon.cc:

  #ifdef HAVE_DAEMON_OFFLOAD_HOOK
        /* Use our build hook for distributed builds by default.  */
  =E2=80=A6

Thanks,
Ludo=E2=80=99.