From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6HWr-0006i1-Pg for guix-patches@gnu.org; Sun, 22 Oct 2017 10:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6HWo-0004Ph-M6 for guix-patches@gnu.org; Sun, 22 Oct 2017 10:47:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47337) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6HWo-0004Pc-Hp for guix-patches@gnu.org; Sun, 22 Oct 2017 10:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e6HWo-00075A-5B for guix-patches@gnu.org; Sun, 22 Oct 2017 10:47:02 -0400 Subject: [bug#28841] [PATCH 03/24] gnu: Add java-eclipse-jetty-test-helper. Resent-Message-ID: References: <20171014233216.49c852f7@lepiller.eu> <20171014222349.12902-1-julien@lepiller.eu> <20171014222349.12902-3-julien@lepiller.eu> <87bml441uv.fsf@elephly.net> <20171022141140.5df9b932@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20171022141140.5df9b932@lepiller.eu> Date: Sun, 22 Oct 2017 16:46:17 +0200 Message-ID: <87vaj7tf46.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 28841@debbugs.gnu.org Julien Lepiller writes: > Le Thu, 19 Oct 2017 11:57:07 +0200, > julien lepiller a écrit : > >> Le 2017-10-18 22:50, Ricardo Wurmus a écrit: >> > Hi Julien, >> > >> >> From: Julien Lepiller >> >> >> >> * gnu/packages/java.scm (java-eclipse-jetty-test-helper): New >> >> variable. >> > >> > […] >> > >> > I wonder: is there a better place for this than java.scm? The same >> > question applies to all other patches in this series. Let’s try to >> > avoid a second python.scm situation :) >> >> eclipse.scm? Or maybe maven.scm, with all other maven bootstrap >> dependencies (and maven itself)? Or maven-bootstrap.scm, maven.scm >> being for the complete maven built with maven-bootstrap, and all the >> plugins of maven? > > So, I've corrected all your comments, except this one, and I don't want > to push without some sort of a consensus. Do I add these packages to > java.scm, eclipse.scm, maven.scm, maven-bootstrap.scm? Since Eclipse Jetty is a Java HTTP server I’d just put it in web.scm. Please also make sure that the description says something like “…helper classes for the Jetty HTTP server…” or similar. I could imagine an “eclipse” module to grow a lot, because there’s so much software under than umbrella. And since Jetty is usable without Maven I think it really shouldn’t just be put in a new maven.scm. Does this make sense? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net