From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOsJS-0005Ti-B7 for guix-patches@gnu.org; Tue, 12 Dec 2017 16:42:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOsJP-0000PR-6M for guix-patches@gnu.org; Tue, 12 Dec 2017 16:42:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOsJP-0000Ox-1w for guix-patches@gnu.org; Tue, 12 Dec 2017 16:42:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOsJO-0005x5-Kx for guix-patches@gnu.org; Tue, 12 Dec 2017 16:42:02 -0500 Subject: bug#28769: [PATCH] gnu: services: Add php-fpm. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <9fe1701f-d78f-ba3a-37eb-64417337a55b@cock.li> <20171013223729.2605f33c@cbaines.net> <7462cec0-7d33-f2a3-1bd7-92454d690b0b@cock.li> <20171102191708.0cf85810@cbaines.net> <145a6af6-bf20-c6e3-f314-009a17239f89@cock.li> <874loz7dw7.fsf@cbaines.net> <0c7cab39-a15e-c8cf-36f5-f6d60d2ba59e@cock.li> From: Christopher Baines In-reply-to: <0c7cab39-a15e-c8cf-36f5-f6d60d2ba59e@cock.li> Date: Tue, 12 Dec 2017 21:41:41 +0000 Message-ID: <87vahb62ui.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: nee Cc: 28769-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable nee writes: > Am 09.12.2017 um 23:08 schrieb Christopher Baines: >> I've attached some changes that I thought would be good when I was >> looking through this. To give a rough summary: >>=20 >> - Minor improvements to the docs, either content, markup or formatting. >> - Removing trailing whitespace. >> - Removing the changes to the nginx-service, in favour of changing the >> default socket group. >> - Change some indentation to avoid long lines. >>=20 >> By changing the default socket group, the system test passes, even >> without the changes to the nginx service. I think this is a bit better, >> and while it's definately not perfect, I think it would be ok to merge >> with this change. >>=20 > Looks all good to me. Thanks for all these style fixes. > >> To also try and move the first patch forward, I've submitted that within >> #29629, with an additional patch to get other services using >> version-major. >>=20 > Thanks, good to see it used at some other spots already. > >> It would be good to get your thoughts on the changes in the attached >> patch, and then if you could send an updated set of patches, that would >> be great. As far as I remember, the changes to the nginx service were >> the only thing I felt needed addressing before merging this. > > The changes look good to me. > I have no edits to add, imo the patches can be squashed merged. Great, I've now rebased and pushed this. Good job :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlowTRVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfpyRAAuTGDESUDk72w+HNF1h1VoxyIOaq0zsvYvWbZo76l/VqQwAWk20T1obbf FNQc9mA4Ylzz4OQ7m622oHjy5krQIPgi/U7ko3GzTIoX+u0EVQyyBAPfR8Sd9i4L tHnKbdPjECyORr+FxCFflc8Ms5mmlAztxI0SZTTkpDbeSLoain4Owh0j1uSrLnL1 xwoQ/PtyuXYWZHX4i+M1gVUXb89VuvhWFlydnYB/8DA9RVFYkQ/OG/UsHAGEJP6k rFngf7mzzUrevIp2YtjXVlNn2Vgvofw1JWi9VnRoNhyYx0dWYbz0dEbqNnWShQit 746Z5dCl1sOUHR9vetyms9rwZ7f7xZfUildHYngdPcpU1c7fr9V+L9u/o007Q/7f jNqSsnSeAyqQpuujovaiEHFY8eFoe9N8dru1L5wp8xWaHcu11BTYYebmEPg1RoIx XURbaAUzHY38gMqymPImUMtnyqJ3WIEMH2B7Tk939fzrtR3XGTLw+JEV57KBw9Rk nTe8sBpbxjbc476zKWpBKFWkhMOzIx918VXfbsHLupFlp/w1zmME9ZB8N0ktLF6n Gag4kCo/MrP6jxQGjTCuq2SkG4dSziXlc8/ujIt2EcRPuKtdLVLNXxUyzxLlerjt bzg4aQvF/GCx2h0PpwotH+u8lDHINgctw+PYt1VtLq/gIRrDmK4= =C1v7 -----END PGP SIGNATURE----- --=-=-=--