From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee4c3-0004Ph-Lz for guix-patches@gnu.org; Tue, 23 Jan 2018 14:52:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee4by-0002jC-QY for guix-patches@gnu.org; Tue, 23 Jan 2018 14:52:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee4by-0002j3-MQ for guix-patches@gnu.org; Tue, 23 Jan 2018 14:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee4by-00074x-Eh for guix-patches@gnu.org; Tue, 23 Jan 2018 14:52:02 -0500 Subject: [bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags. Resent-Message-ID: References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-3-mail@cbaines.net> <20180122215447.GD15170@jasmine.lan> From: Christopher Baines In-reply-to: <20180122215447.GD15170@jasmine.lan> Date: Tue, 23 Jan 2018 19:51:06 +0000 Message-ID: <87vafs5p79.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30214@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote: >> * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New variabl= e. > >> + (add-after 'unpack 'rename-archive >> + (lambda _ >> + (rename-file >> + ,(string-append "src/github.com/jessevdk/go-flags-" versi= on) >> + "src/github.com/jessevdk/go-flags") >> + #t))))) > > I notice a few of these changes in your patch series. Can you give some > detail about what's going on? > > If someone were developing with this library in the typical Go way, > outside of Guix, would they have a problem here? > > Should the go-build-system try to handle this automatically? I believe this might be connected with what is in the source tarball. Without this stage, the go-flags directory is called go-flags-1.3.0, and this causes the build to fail [2]. I'm not sure about the wider context, but it would be good to handle this automatically. 1: =E2=86=92 ls /tmp/guix-build-go-github.com-jessevdk-go-flags-1.3.0.drv-0/sr= c/github.com/jessevdk/ go-flags-1.3.0 2: starting phase `build' can't load package: package github.com/jessevdk/go-flags: cannot find packa= ge "github.com/jessevdk/go-flags" in any of: /gnu/store/9xvc0ml2dfgb58vlbc4sl6mv360jyh84-go-1.9.2/src/github.com/jessev= dk/go-flags (from $GOROOT) /tmp/guix-build-go-github.com-jessevdk-go-flags-1.3.0.drv-0/src/github.com= /jessevdk/go-flags (from $GOPATH) Building 'github.com/jessevdk/go-flags' failed. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpnkipfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xcg8Q/7BCbhwxFD4amXTmnb9+mwilQQaHxGNe3phwt4lgLM5P4BFcGvE5j/5KWi 2MU7zrYSOE/e6scdnQ92rfaG9Krrisaqbd3c10RbKfg+wfs++5QAB9CbrtDK+AhZ SAidb1AOULJ3cpAgvQ+QCrlt6xpSB2xdgaeo2LmJglIDPSIBVMvib7vMiWT2JEJz lC+tAAGl1zSCxpW7kNaHIwzr7xtx9cmtiXoP8VFqoSw8t48ovdcsevcJhTdOxufz OQ64wOplgvsNDaGVpBdON9cWOBGxgWCVBMYzr6i5GApMoz+5AaLAY3MimVrkcPpw yCS7HwXdTAU6vgS0sTRpAlqPq94IIiHj3n09TPPVog50nQH+zyaiXbSGSlmgaFBf qA3Ps6S5Eu/T60reecUZAYAFPD0ZbtfQXLYvgjJ8hQp+CLDB27oRAxtoQGOfvTRz volpHou3lovVwDpyadlwOsC9W3ciwZKxCc3bPoRfSWTj57tZ9rKwrXqYL9UK4zlp BwdjCyL++Kcz7rewVLkLT9DReU4s1ihAatcnkP0rY2ySSug5FBuTSreD3Ir76Sdx pHfl4wWeE65DlCp6TZZSvtC690IUQ6+kLmGA/hLu1bCTnWAeY2fuVloxGsjdIFWk lTQ72Afrf1ZIH22iFFbxB8/RtGfLExss0hjf91FCln3i/2QJmEY= =0CWx -----END PGP SIGNATURE----- --=-=-=--