From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: bug#30394: ARM compilation via qemu binfmt - Assertion failure
Date: Fri, 16 Feb 2018 11:35:43 +0100
Message-ID: <87vaexp6gw.fsf@gnu.org>
References: <87bmh4qrf5.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me>
	<87bmh3kbd9.fsf@gnu.org>
	<87k1vqv23v.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me>
	<20180208174238.2abc85dc@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1emdMt-0001cs-F5
	for guix-devel@gnu.org; Fri, 16 Feb 2018 05:35:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1emdMo-0000IR-H2
	for guix-devel@gnu.org; Fri, 16 Feb 2018 05:35:51 -0500
Received: from hera.aquilenet.fr ([185.233.100.1]:56228)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1emdMo-0000Hh-A5
	for guix-devel@gnu.org; Fri, 16 Feb 2018 05:35:46 -0500
In-Reply-To: <20180208174238.2abc85dc@scratchpost.org> (Danny Milosavljevic's
	message of "Thu, 8 Feb 2018 17:42:38 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, 30394@debbugs.gnu.org, ng0@n0.is

Hello,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Unfortunately, there's a (pretty reproducible) problem with it.
>
> guix-master/guix $ ./pre-inst-env guix system disk-image --system=3Darmhf=
-linux -e "(@ (gnu system install) installation-os)"
> [... building grub-2.02 ...]
> phase `configure' succeeded after 821.8 seconds
> starting phase `patch-generated-file-shebangs'
> patch-makefile-SHELL: ./po/Makefile: changing `SHELL' from `/bin/sh' to `=
/gnu/st[...]
> phase `patch-generated-file-shebangs' succeeded after 14.6 seconds
> starting phase `build'
> bison -d -p grub_script_yy -b grub_script ./grub-core/script/parser.y
> flex -o grub_script.yy.c --header-file=3Dgrub_script.yy.h ./grub-core/scr=
ipt/yylex[...]
> bison: ../sysdeps/unix/sysv/linux/spawni.c:360: __spawnix: Assertion `ec =
>=3D 0' failed

[...]

> https://sourceware.org/bugzilla/show_bug.cgi?id=3D22273
> diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/s=
pawni.c
> index dea1650..f02ac19 100644
> --- a/sysdeps/unix/sysv/linux/spawni.c
> +++ b/sysdeps/unix/sysv/linux/spawni.c
> @@ -365,9 +365,15 @@ __spawnix (pid_t * pid, const char *file,
>    if (new_pid > 0)
>      {
>        ec =3D args.err;
> -      assert (ec >=3D 0);
>        if (ec !=3D 0)

Note that this is only a problem for code that uses the =E2=80=98posix_spaw=
n=E2=80=99
interface, such as Bison in the example above.

In practice that interface is rarely used, which is probably why I never
hit that assertion before.

Ludo=E2=80=99.