From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48238)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1epwwH-0003Si-RK
	for guix-patches@gnu.org; Sun, 25 Feb 2018 09:06:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1epwwE-00038v-NC
	for guix-patches@gnu.org; Sun, 25 Feb 2018 09:06:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:51645)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1epwwE-00038m-Ju
	for guix-patches@gnu.org; Sun, 25 Feb 2018 09:06:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1epwwE-0000MF-Cg
	for guix-patches@gnu.org; Sun, 25 Feb 2018 09:06:02 -0500
Subject: [bug#30604] [PATCH 3/4] linux-initrd: Add kmod.
Resent-Message-ID: <handler.30604.B30604.15195675351332@debbugs.gnu.org>
References: <20180225114557.816-1-dannym@scratchpost.org>
	<20180225114816.869-1-dannym@scratchpost.org>
	<20180225114816.869-3-dannym@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20180225114816.869-3-dannym@scratchpost.org>
Date: Sun, 25 Feb 2018 15:05:24 +0100
Message-ID: <87vaelf9ln.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30604@debbugs.gnu.org


Hi Danny,

Here are some small remarks,

> +    ;; Make modprobe available as /sbin/modprobe so the kernel finds it.
> +    (if kmod
> +        (begin

You can use "when" to avoid "begin".

> +          (define version
> +            (car

Prefer match to car/cdr use.

> +             (filter
> +              (lambda (name)
> +                (not (string-prefix? "." name)))
> +              (scandir module-dir))))
> +
> +          (display "VERSION")
> +          (display version)
> +          (newline)

(format #t "VERSION" ~a~%" version) would be shorter.

> +                  ; -E

Why is this commented ?

> +                  "-F" (string-append #$linux "/System.map")
> +                  version)
> +          #t)))
>  

Thanks,

Mathieu