From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1H1J-0002Ac-Jx for guix-patches@gnu.org; Wed, 28 Mar 2018 15:46:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1H1G-0001z7-FZ for guix-patches@gnu.org; Wed, 28 Mar 2018 15:46:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1H1G-0001yw-97 for guix-patches@gnu.org; Wed, 28 Mar 2018 15:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f1H1F-0006EB-UH for guix-patches@gnu.org; Wed, 28 Mar 2018 15:46:01 -0400 Subject: [bug#30894] Submission of patch for Add r-abc Resent-Message-ID: References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> From: Ricardo Wurmus In-reply-to: <87tvt9azl6.fsf@elephly.net> Date: Wed, 28 Mar 2018 21:44:26 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87vadgdlyd.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Sahithi Yarlagadda Cc: 30894@debbugs.gnu.org Hi Sahiti, have you been able to look at my review below? Please let me know if anything is unclear. ~~ Ricardo Ricardo Wurmus writes: > Hi Sahithi, > >> I am submitting a patch for r-abc. Please review. > > Thank you for the patch! > > What follows is a short review that includes things I could change > myself before applying the patch, but for the sake of learning I > explicitly point out in this message. I hope you don=E2=80=99t mind that= I=E2=80=99m > focusing on what may seem like minor details. > >> From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001 >> From: Sahithi Yarlagadda >> Date: Wed, 21 Mar 2018 16:30:18 +0530 >> Subject: [PATCH] gnu: Add r-abc. >> >> * gnu/packages/cran.scm (r-abc): New variable. > > Nitpick: please don=E2=80=99t indent this line. The asterisk should be t= he > first character in this line. > >> + >> +(define-public r-abc >> + (package >> + (name "r-abc") >> + (version "2.1") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (cran-uri "abc" version)) >> + (sha256 >> + (base32 >> + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) >> + (build-system r-build-system) >> + (propagated-inputs >> + `(("r-abc-data" ,r-abc-data) >> + ("r-locfit" ,r-locfit) >> + ("r-mass" ,r-mass) >> + ("r-nnet" ,r-nnet) >> + ("r-quantreg" ,r-quantreg))) >> + (home-page >> + "http://cran.r-project.org/web/packages/abc") > > Please pull this onto the previous line and use =E2=80=9Chttps=E2=80=9D. > >> + (synopsis >> + "Tools for approximate bayesian computation (ABC)") > > Please combine this line with the previous line. > >> + (description >> + "Implements several ABC algorithms for performing parameter estim= ation, >> +model selection, and goodness-of-fit. Cross-validation tools are also >> +available for measuring the accuracy of ABC estimates, and to calculate= the >> +misclassification probabilities of different models.") > > Please use full sentences. For CRAN packages the official description > usually provides only a sentence fragment in place of the first > sentence. Please also use =E2=80=9C@dfn{Approximate Bayesian Computation= } > (ABC)=E2=80=9D the first time =E2=80=9CABC=E2=80=9D is mentioned. > > All thoughout the indentation is a bit off (that=E2=80=99s expected as th= e > importer is very simple and doesn=E2=80=99t know about the expected > indentation). If you=E2=80=99re using Emacs you can easily adjust it wit= h M-C-q > (also known as =E2=80=9Cindent-sexp=E2=80=9D); otherwise please use > =E2=80=9Cetc/indent-code.el=E2=80=9D. > > Have you built this package with Guix? > > Finally, please rebase this patch so that it can be applied > independently from the other patch you=E2=80=99ve sent, which cannot curr= ently > be applied due to problems in building the defined package. Rebasing > this patch ensures that it can be merged even if the other patch is > stuck. > > Thanks!