From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2LiT-00029z-Pr for guix-patches@gnu.org; Sat, 31 Mar 2018 14:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2LiR-0006aJ-6D for guix-patches@gnu.org; Sat, 31 Mar 2018 14:59:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53601) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2LiQ-0006aD-UD for guix-patches@gnu.org; Sat, 31 Mar 2018 14:59:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f2LiQ-0000qk-O1 for guix-patches@gnu.org; Sat, 31 Mar 2018 14:59:02 -0400 Subject: bug#30259: [PATCH] gnu: octave: Add audio and Qt GUI support. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20180126151311.9049-1-kkebreau@posteo.net> <87wp04fpjs.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87po5wfmui.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87372scat2.fsf@posteo.net> <877es3zmla.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87y3kjatrn.fsf@posteo.net> <87607mn846.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <20180317152552.eui5w7e275sx4ohu@abyayala> <87y3i870o7.fsf@posteo.net> Date: Sat, 31 Mar 2018 14:58:06 -0400 In-Reply-To: <87y3i870o7.fsf@posteo.net> (Kei Kebreau's message of "Sat, 31 Mar 2018 10:57:28 -0400") Message-ID: <87vadc6pj5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30259-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Kei Kebreau writes: > ng0 writes: > >> ng0@n0.is transcribed 2.4K bytes: >>> On Sat, 27 Jan 2018, Kei Kebreau wrote: >>> > ng0+guixpatches@n0.is writes: >>> > >>> >> On Fri, 26 Jan 2018, Kei Kebreau wrote: >>> >>> ng0+guixpatches@n0.is writes: >>> >>> >>> >>>> On Fri, 26 Jan 2018, ng0+guixpatches@n0.is wrote: >>> >>>>> On Fri, 26 Jan 2018, Kei Kebreau wrote: >>> >>>>>> * gnu/packages/maths.scm (octave)[inputs]: Add qscintilla, >>> >>>>>> qt, suitesparse, >>> >>>>>> libsndfile, portaudio and alsa-lib. >>> >>>>>> [native-inputs]: Add qttools. >>> >>>>>> [arguments]: Add 'patch-qscintilla-library-name' phase. >>> >>>>> >>> >>>>> Woo! Nice :) I've started work on the Qt GUI a while ago but >>> >>>>> never finished it. Do you think we should split this into octave >>> >>>>> and octave-qt (or octave-gui)? Qt is quiet huge and not everyone >>> >>>>> will want this I think. >>> >>>>> >>> >>>>> Building this now and getting back to you with results. >>> >>>>> >>> >> [=E2=80=A6] >>> >>>> Build, compiled, installed, LGTM and works for me. At least the >>> >>>> minimal basics I've tested. >>> >>>> >>> >>> >>> >>> Excellent! Thanks for testing this. >>> >>> >>> >>>> However I still think we should split it later on. I'm not sure >>> >>>> if other systems just provide it in one piece or if they provide >>> >>>> octave-cli, octave-qt, etc. >>> >>>> In my scenario we don't have substitutes for Qt all the time and >>> >>>> someone running a >>> >>>> machine which isn't capable of building Qt wants to use octave. >>> >>> >>> >>> I agree that this package should be split. Should a split be made n= ow >>> >>> while we leave the lighter CLI-only Octave package available on mas= ter, >>> >>> or should it be postponed until later on? >>> >>> >>> >> >>> >> It could be done later on, but if you think it wouldn't be too >>> >> much work you could do it now. >>> > >>> > Done, I think! >>> > >>> >> Ideally this would leave 'octave' as it is and add >>> >> 'octave-whatever' ... octave-qt? Debian calls the package (with >>> >> just the Qt Gui) "qtoctave". octave-* should be reserved for >>> >> extensions (which we don't have right now), so maybe qtoctave >>> >> would fit into our naming scheme? >>> >> >>> >> >>> >> / I think I'm going to switch the subscribed address once more, >>> >> now that I have proper filtering I don't need the server-side >>> >> filtering. / >>> > >>> > Can you (and/or any bystanders reading this) test these? >>> > >>> > >>> > >>>=20 >>> LGTM. >>>=20 >>> qtoctave worked, the normal octave should be alright. >>>=20 >>> Thank you very much for the work on this. >> >> Can someone push this? If nothing changed since the review I did, it's >> good to go and just catching digital dust. Patch still applies iirc as >> I build my active branch with it. > > Sorry for the delay! I've been swamped with other work. I'll be pushing > this today as soon as I build and lint it on my computer. Thanks for > your help! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlq/2j8ACgkQ5qXuPBlG eg1nJQ//XNNadQGWQPFyTvepNmnuJmgzgHrOLwtLdl8ghFrIKJpfsbVxzpcnS1QR 0Cg0c407eATe5bK2O/6BD0W7szsgQNV4+Li8vMYSQuMcwmVgs4qxRUjhOL2r9Zwn hfKM8IkV0ayhU4UfQMs4CSjhCldZbjOGN3Uwvxb56w9CyFt3soOHowF7NnjAyjiN l5F8e9KUUYCc31a4kuQo9JO1ABRvnSj1wINHCwQ/8+m4HqmhCq95I6hxCLsZjho1 GLKwA0exz1rjNecfpxjJeFd5gkPMmJyhqaqqYepFCVf5votXGuiWQ5XSOEY8TkbA 4F3XtqtlONxlK9/f31ZUoL1EltelzBpf1s/Q3xrgGPPceSaXgrAsAM4w9k7xkl8u cIT3Ekf86OYrfONeUisBo6ubQO9GKLOnxyo9fYIXoBBOanvNUUwthMu0kbsP7MD6 37BtIiK7S2WrIWyOc6xJ8+OcFIKdbdLSNViU+gTi7cGdyvVC6G19NNqllEaC4bYA alfNpcQ7evJ0nxioYdcbEm6qtHO+uCjDuuejzewl297cmbGSXEws27k+viZVPh2/ BafNctwnWypkGRte/ufEZ77Etzv0N9CI2ViRoG2F+UofrQWuYQb44OOhiElsRxqg AI+159BuDkpzsdmsO/SlLlIpzI239yr7Z8WGFMJP8Wky783qyxw= =fOjS -----END PGP SIGNATURE----- --=-=-=--