[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Sohom Bhattacharjee]

I added the comment because it makes it clear as to why the "v" is needed in the version. 
* gnu/packages/emacs.scm (emacs-dumb-jump): New variable.
---
 gnu/packages/emacs.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7a203ef6e..b4744cfc9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7436,3 +7436,37 @@ directories of plain text notes, inspired by Notational Velocity.")
 matches\" in the mode line in various search modes.  This is an Emacs port of
 Anzu.zim.")
     (license license:gpl3+)))
+
+;; the version needs to have a v in it because of how the github releases are maintained.
+(define-public emacs-dumb-jump
+(package
+  (name "emacs-dumb-jump")
+  (version "v0.5.2")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+            "https://github.com/jacktasia/dumb-jump/archive/"
+             version ".tar.gz"))
+      (file-name (string-append name "-" version ".tar.gz"))
+      (sha256
+        (base32
+          "07n0xjgpxjpf3vp9gxchkjpydyj0zm166930as0kwiwkhjlsirsf"))))
+  (build-system emacs-build-system)
+  (propagated-inputs
+    `(("emacs-f" ,emacs-f)
+      ("emacs-s" ,emacs-s)
+      ("emacs-dash" ,emacs-dash)
+      ("emacs-popup" ,emacs-popup)))
+  (home-page "https://github.com/jacktasia/dumb-jump")
+  (synopsis
+    "Jump to definition for multiple languages without configuration")
+  (description
+    "Dumb Jump is an Emacs \"jump to definition\" package with support for
+multiple programming languages that favors \"just working\" over speed or
+accuracy.  This means minimal -- and ideally zero -- configuration with
+absolutely no stored indexes (TAGS) or persistent background processes.  Dumb
+Jump performs best with The Silver Searcher `ag` or ripgrep `rg` installed.
+Dumb Jump requires at least GNU Emacs 24.3.
+")
+  (license license:gpl3+)))
-- 
2.16.2

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Arun Isaac]

Thank you for contributing to Guix! The following are some changes.

> +;; the version needs to have a v in it because of how the github releases are maintained.
> +(define-public emacs-dumb-jump
> +(package
> +  (name "emacs-dumb-jump")
> +  (version "v0.5.2")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +            "https://github.com/jacktasia/dumb-jump/archive/"
> +             version ".tar.gz"))

We normally include the "v" in the source URI itself, not in the
version. So, you'd end up with the following uri.

(string-append "https://github.com/jacktasia/dumb-jump/archive/v" version ".tar.gz")

> +  (synopsis
> +    "Jump to definition for multiple languages without configuration")
> +  (description
> +    "Dumb Jump is an Emacs \"jump to definition\" package with support for
> +multiple programming languages that favors \"just working\" over speed or
> +accuracy.  This means minimal -- and ideally zero -- configuration with
> +absolutely no stored indexes (TAGS) or persistent background processes.  Dumb

Downcase TAGS to tags.

> +Jump performs best with The Silver Searcher `ag` or ripgrep `rg` installed.

Please put ag and rg within @command{} -- @command{ag} and @command{rg}.

This package appears to have tests. Could you add a check phase for
running them?

Also, the first line of the commit message should read

gnu: Add emacs-dumb-jump.

not

gnu: Add Emacs dumb-jump.

Could you send an updated patch?

Thanks!

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Sohom Bhattacharjee]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

I made the changes as suggested. However i can not get the tests working. 

I need some help with the tests. 

whenever i compile this package i get these errors

phase `unpack' succeeded after 0.0 seconds
starting phase `patch-usr-bin-file'
phase `patch-usr-bin-file' succeeded after 0.0 seconds
starting phase `patch-source-shebangs'
phase `patch-source-shebangs' succeeded after 0.0 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `check'
test suite not run
phase `check' succeeded after 0.0 seconds
starting phase `install'
`/tmp/guix-build-emacs-dumb-jump-0.5.2.drv-0/dumb-jump-0.5.2/dumb-jump.el' -> 
`/gnu/store/7rwqglwmjf6dbgfq87n642acp14agwsr-emacs-dumb-jump-0.5.2/share/emacs/site-lisp/guix.d/dumb-jump-0.5.2/dumb-jump.el'
phase `install' succeeded after 0.0 seconds
starting phase `check'
Cannot open load file: No such file or directory, undercover
phase `check' failed after 0.1 seconds
builder for `/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
@ build-failed /gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv - 1 builder for 
`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv' failed




[-- Attachment #2: 0001-gnu-Add-emacs-dumb-jump.patch --]
[-- Type: text/plain, Size: 2402 bytes --]

From 218c7cb718cf2d48cebab8bdaef4320283527b0a Mon Sep 17 00:00:00 2001
From: Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com>
Date: Mon, 9 Apr 2018 20:22:53 +0530
Subject: [PATCH] gnu: Add emacs-dumb-jump

* gnu/packages/emacs.scm (emacs-dumb-jump): New variable.
---
 gnu/packages/emacs.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb722844c..db1d436b6 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7539,3 +7539,46 @@ and can be consulted and modified.")
     (description "@code{anzu} provides a minor mode that displays the current
 match and total match information in the mode-line in various search modes.")
     (license license:gpl3+)))
+
+(define-public emacs-dumb-jump
+  (package
+    (name "emacs-dumb-jump")
+    (version "0.5.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/jacktasia/dumb-jump/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07n0xjgpxjpf3vp9gxchkjpydyj0zm166930as0kwiwkhjlsirsf"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-f" ,emacs-f)
+       ("emacs-s" ,emacs-s)
+       ("emacs-dash" ,emacs-dash)
+       ("emacs-popup" ,emacs-popup)))
+    (native-inputs
+     `(("ert-runner" ,ert-runner)
+       ("emacs-undercover" ,emacs-undercover)
+       ("emacs-el-mock" ,emacs-el-mock)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'check
+           (lambda _
+             (zero? (system* "ert-runner")))))))
+    (home-page "https://github.com/jacktasia/dumb-jump")
+    (synopsis
+     "Jump to definition for multiple languages without configuration")
+    (description
+     "Dumb Jump is an Emacs \"jump to definition\" package with support for
+multiple programming languages that favors \"just working\" over speed or
+accuracy.  This means minimal -- and ideally zero -- configuration with
+absolutely no stored indexes (tags) or persistent background processes.  Dumb
+Jump performs best with The Silver Searcher @command{ag} or ripgrep @comand{rg} installed.
+Dumb Jump requires at least GNU Emacs 24.3.
+")
+    (license license:gpl3+)))
-- 
2.16.2

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Maxim Cournoyer]

On April 9, 2018 3:00:08 PM UTC, Sohom Bhattacharjee es<soham.bhattacharjee15@gmail.com> wrote:
>I made the changes as suggested. However i can not get the tests
>working. 
>
>I need some help with the tests. 
>
>whenever i compile this package i get these errors
>
>phase `unpack' succeeded after 0.0 seconds
>starting phase `patch-usr-bin-file'
>phase `patch-usr-bin-file' succeeded after 0.0 seconds
>starting phase `patch-source-shebangs'
>phase `patch-source-shebangs' succeeded after 0.0 seconds
>starting phase `patch-generated-file-shebangs'
>phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
>starting phase `check'
>test suite not run
>phase `check' succeeded after 0.0 seconds
>starting phase `install'
>`/tmp/guix-build-emacs-dumb-jump-0.5.2.drv-0/dumb-jump-0.5.2/dumb-jump.el'
>-> 
>`/gnu/store/7rwqglwmjf6dbgfq87n642acp14agwsr-emacs-dumb-jump-0.5.2/share/emacs/site-lisp/guix.d/dumb-jump-0.5.2/dumb-jump.el'
>phase `install' succeeded after 0.0 seconds
>starting phase `check'
>Cannot open load file: No such file or directory, undercover
>phase `check' failed after 0.1 seconds
>builder for
>`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv'
>failed with exit code 1
>@ build-failed
>/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv -
>1 builder for 
>`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv'
>failed with exit code 1
>guix build: error: build failed: build of
>`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv'
>failed

I believe this is because the ert-runner wrapper script completely overrides the EMACSLOADPATH env. variable used to make the different dependencies visible to Emacs in our emacs-build-system.

The fix to this particular bug is included in patch 0003 of a patch series waiting to be reviewed here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31018.

You might want to retry your test after applying that specific patch.

HTH,

Maxim
Hello!

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Sohom Bhattacharjee]

On Mon, Apr 09, 2018 at 04:12:07PM +0000, Maxim Cournoyer wrote:
> On April 9, 2018 3:00:08 PM UTC, Sohom Bhattacharjee es<soham.bhattacharjee15@gmail.com> wrote:
> >I made the changes as suggested. However i can not get the tests
> >working. 
> >
> >I need some help with the tests. 
> >
> >whenever i compile this package i get these errors
> >
> >phase `unpack' succeeded after 0.0 seconds
> >starting phase `patch-usr-bin-file'
> >phase `patch-usr-bin-file' succeeded after 0.0 seconds
> >starting phase `patch-source-shebangs'
> >phase `patch-source-shebangs' succeeded after 0.0 seconds
> >starting phase `patch-generated-file-shebangs'
> >phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
> >starting phase `check'
> >test suite not run
> >phase `check' succeeded after 0.0 seconds
> >starting phase `install'
> >`/tmp/guix-build-emacs-dumb-jump-0.5.2.drv-0/dumb-jump-0.5.2/dumb-jump.el'
> >-> 
> >`/gnu/store/7rwqglwmjf6dbgfq87n642acp14agwsr-emacs-dumb-jump-0.5.2/share/emacs/site-lisp/guix.d/dumb-jump-0.5.2/dumb-jump.el'
> >phase `install' succeeded after 0.0 seconds
> >starting phase `check'
> >Cannot open load file: No such file or directory, undercover
> >phase `check' failed after 0.1 seconds
> >builder for
> >`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv'
> >failed with exit code 1
> >@ build-failed
> >/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv -
> >1 builder for 
> >`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv'
> >failed with exit code 1
> >guix build: error: build failed: build of
> >`/gnu/store/sx8j4pi37d8i32m9hraahkbn1m0ckks6-emacs-dumb-jump-0.5.2.drv'
> >failed
> 
> I believe this is because the ert-runner wrapper script completely overrides the EMACSLOADPATH env. variable used to make the different dependencies visible to Emacs in our emacs-build-system.
> 
> The fix to this particular bug is included in patch 0003 of a patch series waiting to be reviewed here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31018.
>  
> You might want to retry your test after applying that specific patch.
> 
> HTH,
> 
> Maxim
> Hello!

I applied the said patch and build guix. Then I tried to build dumb-jump. This led to the following error.

I think that the patch worked because this error says something about "noflet". (i might be wrong..)

Here is the error.

phase `unpack' succeeded after 0.0 seconds
starting phase `patch-usr-bin-file'
phase `patch-usr-bin-file' succeeded after 0.0 seconds
starting phase `patch-source-shebangs'
phase `patch-source-shebangs' succeeded after 0.0 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `check'
test suite not run
phase `check' succeeded after 0.0 seconds
starting phase `install'
`/tmp/guix-build-emacs-dumb-jump-0.5.2.drv-0/dumb-jump-0.5.2/dumb-jump.el' -> 
`/gnu/store/vvfvxp79ngf8a88saskp62aqqnfsmyav-emacs-dumb-jump-0.5.2/share/emacs/site-lisp/guix.d/dumb-jump-0.5.2/dumb-jump.el'
phase `install' succeeded after 0.0 seconds
starting phase `check'
Cannot open load file: No such file or directory, noflet
phase `check' failed after 0.2 seconds
builder for `/gnu/store/3n35rfqwsw3dl8y4zkfb4zh957diw3ax-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
@ build-failed /gnu/store/3n35rfqwsw3dl8y4zkfb4zh957diw3ax-emacs-dumb-jump-0.5.2.drv - 1 builder for 
`/gnu/store/3n35rfqwsw3dl8y4zkfb4zh957diw3ax-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/3n35rfqwsw3dl8y4zkfb4zh957diw3ax-emacs-dumb-jump-0.5.2.drv' failed


Thanks,

Sohom!

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Arun Isaac]

Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com> writes:

> I applied the said patch and build guix. Then I tried to build
> dumb-jump. This led to the following error.
>
> I think that the patch worked because this error says something about
> "noflet". (i might be wrong..)

You are getting this error because noflet is a test dependency. See
https://github.com/jacktasia/dumb-jump/blob/master/Cask . Therefore,
noflet (and the others mentioned in Cask) should be in native-inputs.

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Sohom Bhattacharjee]

[-- Attachment #1: Type: text/plain, Size: 2265 bytes --]

On Wed, Apr 11, 2018 at 10:48:44AM +0530, Arun Isaac wrote:
> Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com> writes:
> 
> > I applied the said patch and build guix. Then I tried to build
> > dumb-jump. This led to the following error.
> >
> > I think that the patch worked because this error says something about
> > "noflet". (i might be wrong..)
> 
> You are getting this error because noflet is a test dependency. See
> https://github.com/jacktasia/dumb-jump/blob/master/Cask . Therefore,
> noflet (and the others mentioned in Cask) should be in native-inputs.

I am sending 2 patches. In the first one I have added the package emacs-noflet package (patch 0001) which is a test dependency for the 
emacs-dumb-jump package.

In the second patch I have made the neccesary changes to the emacs-dumb-jump package. 

Even then it is not building properly. I am getting these errors

phase `unpack' succeeded after 0.0 seconds
starting phase `patch-usr-bin-file'
phase `patch-usr-bin-file' succeeded after 0.0 seconds
starting phase `patch-source-shebangs'
phase `patch-source-shebangs' succeeded after 0.0 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `check'
test suite not run
phase `check' succeeded after 0.0 seconds
starting phase `install'
`/tmp/guix-build-emacs-dumb-jump-0.5.2.drv-0/dumb-jump-0.5.2/dumb-jump.el' -> 
`/gnu/store/k19qy6b8kbl59xfh6d9ji064mj6qjmbz-emacs-dumb-jump-0.5.2/share/emacs/site-lisp/guix.d/dumb-jump-0.5.2/dumb-jump.el'
phase `install' succeeded after 0.0 seconds
starting phase `check'
Searching for program: No such file or directory, /bin/sh
phase `check' failed after 0.3 seconds
builder for `/gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
@ build-failed /gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv - 1 builder for 
`/gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv' failed



NOTE: this is after applying [0003] patch in this series. 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31018

Thank You!! 

[-- Attachment #2: 0001-gnu-Add-emacs-noflet.patch --]
[-- Type: text/plain, Size: 1874 bytes --]

From 41bce34d0bbed656f3d4bcdc65b20e8a9a6c554e Mon Sep 17 00:00:00 2001
From: Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com>
Date: Thu, 12 Apr 2018 12:11:03 +0530
Subject: [PATCH 3/3] gnu: Add emacs-noflet

* gnu/packages/emacs.scm (eamcs-noflet): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 69a5449e6..606614bdb 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7578,7 +7578,28 @@ match and total match information in the mode-line in various search modes.")
 multiple programming languages that favors \"just working\" over speed or
 accuracy.  This means minimal -- and ideally zero -- configuration with
 absolutely no stored indexes (tags) or persistent background processes.  Dumb
-Jump performs best with The Silver Searcher @command{ag} or ripgrep @comand{rg} installed.
-Dumb Jump requires at least GNU Emacs 24.3.
+Jump performs best with The Silver Searcher @command{ag} or ripgrep
+@comand{rg} installed.  Dumb Jump requires at least GNU Emacs 24.3.
 ")
     (license license:gpl3+)))
+
+(define-public emacs-noflet
+  (package
+  (name "emacs-noflet")
+  (version "20141102.654")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append "https://melpa.org/packages/noflet-"
+             version ".el"))
+      (sha256
+        (base32
+          "1a1wxb9zhrhj2iv1abjqpggyh5gwg13gwyz1052dqq4fbpbrwa0y"))))
+  (build-system emacs-build-system)
+  (home-page "https://github.com/nicferrier/emacs-noflet")
+  (synopsis "locally override functions")
+  (description
+    "This let's you locally override functions, in the manner of
+@command{flet}, but with access to the original function through the symbol:
+@command{this-fn}.")
+  (license license:gpl3+)))
-- 
2.16.2


[-- Attachment #3: 0002-gnu-Add-emacs-dumb-jump.patch --]
[-- Type: text/plain, Size: 2419 bytes --]

From dfc5c83a2d192eb8352b374510ea96de86fac4eb Mon Sep 17 00:00:00 2001
From: Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com>
Date: Mon, 9 Apr 2018 20:22:53 +0530
Subject: [PATCH 2/3] gnu: Add emacs-dumb-jump

* gnu/packages/emacs.scm (emacs-dumb-jump): New variable.
---
 gnu/packages/emacs.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e0056d862..69a5449e6 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7539,3 +7539,46 @@ and can be consulted and modified.")
     (description "@code{anzu} provides a minor mode that displays the current
 match and total match information in the mode-line in various search modes.")
     (license license:gpl3+)))
+
+(define-public emacs-dumb-jump
+  (package
+    (name "emacs-dumb-jump")
+    (version "0.5.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/jacktasia/dumb-jump/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07n0xjgpxjpf3vp9gxchkjpydyj0zm166930as0kwiwkhjlsirsf"))))
+    (build-system emacs-build-system)
+    (native-inputs
+     `(("ert-runner" ,ert-runner)
+       ("emacs-undercover" ,emacs-undercover)
+       ("emacs-el-mock" ,emacs-el-mock)
+       ("emacs-f" ,emacs-f)
+       ("emacs-s" ,emacs-s)
+       ("emacs-dash" ,emacs-dash)
+       ("emacs-popup" ,emacs-popup)
+       ("emacs-noflet" ,emacs-noflet)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'check
+           (lambda _
+             (zero? (system* "ert-runner")))))))
+    (home-page "https://github.com/jacktasia/dumb-jump")
+    (synopsis
+     "Jump to definition for multiple languages without configuration")
+    (description
+     "Dumb Jump is an Emacs \"jump to definition\" package with support for
+multiple programming languages that favors \"just working\" over speed or
+accuracy.  This means minimal -- and ideally zero -- configuration with
+absolutely no stored indexes (tags) or persistent background processes.  Dumb
+Jump performs best with The Silver Searcher @command{ag} or ripgrep @comand{rg} installed.
+Dumb Jump requires at least GNU Emacs 24.3.
+")
+    (license license:gpl3+)))
-- 
2.16.2

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Maxim Cournoyer]

Hello Sohom!

Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com> writes:

[...]

> In the second patch I have made the neccesary changes to the emacs-dumb-jump package. 
>
> Even then it is not building properly. I am getting these errors
>
> phase `unpack' succeeded after 0.0 seconds
> starting phase `patch-usr-bin-file'
> phase `patch-usr-bin-file' succeeded after 0.0 seconds
> starting phase `patch-source-shebangs'
> phase `patch-source-shebangs' succeeded after 0.0 seconds
> starting phase `patch-generated-file-shebangs'
> phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
> starting phase `check'
> test suite not run
> phase `check' succeeded after 0.0 seconds
> starting phase `install'
> `/tmp/guix-build-emacs-dumb-jump-0.5.2.drv-0/dumb-jump-0.5.2/dumb-jump.el' -> 
> `/gnu/store/k19qy6b8kbl59xfh6d9ji064mj6qjmbz-emacs-dumb-jump-0.5.2/share/emacs/site-lisp/guix.d/dumb-jump-0.5.2/dumb-jump.el'
> phase `install' succeeded after 0.0 seconds
> starting phase `check'
> Searching for program: No such file or directory, /bin/sh
> phase `check' failed after 0.3 seconds
> builder for `/gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
> @ build-failed /gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv - 1 builder for 
> `/gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv' failed with exit code 1
> guix build: error: build failed: build of `/gnu/store/9qp5nygvablrjzxk3ps46rps5rmx4k38-emacs-dumb-jump-0.5.2.drv' failed
>
> NOTE: this is after applying [0003] patch in this series. 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31018

I applied your changes and gave it a try. I ran in the same problem as you
did. Interestingly I didn't get the same error when ran directly from a
contained environment (with "./pre-inst-env guix environment -C
emacs-dumb-jump", then

--8<---------------cut here---------------start------------->8---
for p in $GUIX_ENVIRONMENT/share/emacs/site-lisp/guix.d/*; do e=":$p:$e"; done
export EMACSLOADPATH=$e"
--8<---------------cut here---------------end--------------->8---

There, the tests just hang after the 3rd test:

--8<---------------cut here---------------start------------->8---
$ ert-runner
Running 143 tests (2018-04-12 23:29:52-0400)

   passed    1/143  data-dir-exists-test
   passed    2/143  data-dir-proj2-exists-test
   passed    3/143  dumb-jump--result-follow-test
--8<---------------cut here---------------end--------------->8---

The tests are potentially broken or tied to a very specific
environment?. I've tried running those on my system (not in a controlled
environment) and it failed the same as in the Guix build container
(hang). Maybe you could ping upstream about it, and disable the tests
for now.

> Thank You!! 
>
>>From 41bce34d0bbed656f3d4bcdc65b20e8a9a6c554e Mon Sep 17 00:00:00 2001
> From: Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com>
> Date: Thu, 12 Apr 2018 12:11:03 +0530
> Subject: [PATCH 3/3] gnu: Add emacs-noflet

[...]

> +(define-public emacs-noflet
> +  (package
> +  (name "emacs-noflet")
> +  (version "20141102.654")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append "https://melpa.org/packages/noflet-"
> +             version ".el"))
> +      (sha256
> +        (base32
> +          "1a1wxb9zhrhj2iv1abjqpggyh5gwg13gwyz1052dqq4fbpbrwa0y"))))
> +  (build-system emacs-build-system)
> +  (home-page "https://github.com/nicferrier/emacs-noflet")
> +  (synopsis "locally override functions")

The "guix lint" command has a small complaint: unknown location>:
emacs-noflet@20141102.654: synopsis should start with an upper-case
letter or digit.

> +(define-public emacs-dumb-jump
> +  (package
> +    (name "emacs-dumb-jump")
> +    (version "0.5.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/jacktasia/dumb-jump/archive/v"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))

We've had issues with Github mutating their tarballs (these are
dynamically generated) before (breaking the hash). For this reason, I
now prefer to use git directly. I encourage others to do the same.

> +       (sha256
> +        (base32
> +         "07n0xjgpxjpf3vp9gxchkjpydyj0zm166930as0kwiwkhjlsirsf"))))
> +    (build-system emacs-build-system)
> +    (native-inputs
> +     `(("ert-runner" ,ert-runner)
> +       ("emacs-undercover" ,emacs-undercover)
> +       ("emacs-el-mock" ,emacs-el-mock)
> +       ("emacs-f" ,emacs-f)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-dash" ,emacs-dash)
> +       ("emacs-popup" ,emacs-popup)
> +       ("emacs-noflet" ,emacs-noflet)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'check

Instead of "add-after 'install 'check", use "replace 'check"
instead. There is already a check phase for the emacs-build-system
(currently the same as for the gnu-build-system, but improved in the
patch set you picked the ert-runner fix from).

> +           (lambda _
> +             (zero? (system* "ert-runner")))))))
> +    (home-page "https://github.com/jacktasia/dumb-jump")
> +    (synopsis
> +     "Jump to definition for multiple languages without configuration")
> +    (description
> +     "Dumb Jump is an Emacs \"jump to definition\" package with support for
> +multiple programming languages that favors \"just working\" over speed or
> +accuracy.  This means minimal -- and ideally zero -- configuration with
> +absolutely no stored indexes (tags) or persistent background processes.  Dumb
> +Jump performs best with The Silver Searcher @command{ag} or ripgrep
> @comand{rg} installed.
     ^
The above typo caused the linter to say: "<unknown
location>: emacs-dumb-jump@0.5.2: Texinfo markup in description is
invalid".

[...]

Thank you,

Maxim

bug#31036: [PATCH] gnu: Add Emacs dumb-jump

[Arun Isaac]

I have pushed both packages emacs-noflet and emacs-dumb-jump.

You had used the MELPA tarball for emacs-noflet. I replaced that with
the upstream git repo.

As Maxim noted, emacs-dumb-jump tests freeze. I pushed for now, without
the tests. The missing "/bin/sh" problem was solved by setting the SHELL
environment variable.

I made many other small changes. Please look at the pushed commits in
master for more information.

Thanks!

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hello Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> I have pushed both packages emacs-noflet and emacs-dumb-jump.

Apologies for not finding this bug report before.  We have duplicates of
‘emacs-dumb-jump’ in Guix package collection, because I've pushed 88
Emacs related patches 3 days ago including ‘emacs-dumb-jump’.

I probably should remove my ‘emacs-dumb-jump’.  Is it OK for you?

[…]

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Arun Isaac]

Oleg Pykhalov <go.wigust@gmail.com> writes:

>> I have pushed both packages emacs-noflet and emacs-dumb-jump.
>
> Apologies for not finding this bug report before.  We have duplicates of
> ‘emacs-dumb-jump’ in Guix package collection, because I've pushed 88
> Emacs related patches 3 days ago including ‘emacs-dumb-jump’.

Sorry for the collision too. But, it's not a big deal. This can be fixed
easily.

> I probably should remove my ‘emacs-dumb-jump’.  Is it OK for you?

Sure, please go ahead and remove one of the duplicate packages. I
believe the version I pushed is a little more complete with
native-inputs and tests (though I couldn't get them working properly).

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

> Oleg Pykhalov <go.wigust@gmail.com> writes:

[…]

>> I probably should remove my ‘emacs-dumb-jump’.  Is it OK for you?
>
> Sure, please go ahead and remove one of the duplicate packages. I
> believe the version I pushed is a little more complete with
> native-inputs and tests (though I couldn't get them working properly).

OK, I've reverted an older package recipe in
8c58640d179a26a1a4cde3d8920bd928edb84d1c

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

[Arun Isaac]

Hello Sohom,

> I believe this is because the ert-runner wrapper script completely
> overrides the EMACSLOADPATH env. variable used to make the different
> dependencies visible to Emacs in our emacs-build-system.
>
> The fix to this particular bug is included in patch 0003 of a patch
> series waiting to be reviewed here:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31018.

Let's revisit this patch after bug 31018 is done. I'm reviewing Maxim's
patches on bug 31018 now. So, hopefully, this won't be long.

Thanks.