From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: next browser (was: Packaging a free Firefox) Date: Thu, 24 May 2018 18:44:47 +0200 Message-ID: <87vabdq9z4.fsf@gmail.com> References: <87y3h1g42q.fsf@lassieur.org> <87wowlg3vu.fsf@lassieur.org> <20180503050020.ljaqgrop6uwy24op@abyayala> <87muxhfhqq.fsf@gmail.com> <876044lsci.fsf@gmail.com> <20180503233604.69fd089c@uwaterloo.ca> <87mux8n5gq.fsf@gmail.com> <20180510020041.1e8b3956@uwaterloo.ca> <87d0y3hije.fsf@gmail.com> <3e43616290027f58207fe54d748183e9.squirrel@mailservices.uwaterloo.ca> <877eobh92c.fsf@gmail.com> <20180511010037.6951035e@uwaterloo.ca> <87efi7wion.fsf@gmail.com> <871se1crci.fsf@elephly.net> <87fu2hw30r.fsf@gmail.com> <87sh6hax0j.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLtMB-00016U-Ml for guix-devel@gnu.org; Thu, 24 May 2018 12:44:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLtMA-0004mP-P2 for guix-devel@gnu.org; Thu, 24 May 2018 12:44:51 -0400 Received: from mail-wr0-x22f.google.com ([2a00:1450:400c:c0c::22f]:32856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLtMA-0004m7-Gk for guix-devel@gnu.org; Thu, 24 May 2018 12:44:50 -0400 Received: by mail-wr0-x22f.google.com with SMTP id a15-v6so4338058wrm.0 for ; Thu, 24 May 2018 09:44:50 -0700 (PDT) In-reply-to: <87sh6hax0j.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > It is sometimes possible to patch the sources by replacing the library > name with the full path of the library. Have you tried that? You are right. I think what we need here is to patch all the cffi packages. For instance, sqlite3-lib contains the following lines: =2D-8<---------------cut here---------------start------------->8--- (define-foreign-library sqlite3-lib (:darwin (:default "libsqlite3")) (:unix (:or "libsqlite3.so.0" "libsqlite3.so")) (t (:or (:default "libsqlite3") (:default "sqlite3")))) =2D-8<---------------cut here---------------end--------------->8--- Patching with the full path should work. I'll see what I can do. Maybe we should think of a function to do that automatically for all cffi packages. Not sure how doable that'd be. > Another option is to wrap the executable in LD_LIBRARY_PATH, although > that should only be a last resort. > >> GuixSD has LIBRARY_PATH=3D~/.guix-profile/lib, can we use that? > > LIBRARY_PATH is only set when you have gcc-toolchain installed. I don=E2= =80=99t > have this variable. It is also not applicable here: it is used by the > compiler at build time when linking applications. So to what would you wrap it? The full path of the required libs? E.g. LD_LIBRARY_PATH=3D/gnu/store/sdin91pj2w7m5avvb6vykh6haq8q2ni0-sqlite-3.21.0= /lib/:... =2D-=20 Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlsG6/8ACgkQm9z0l6S7 zH8kJwf+NvQey1bXp8z9nm9N+0a4MBjJIPKIYw7+SES6GJ/5/oC2WgrXuILVs8/U z24d0FVXUUBOFnIMgMrCZc/XnQz4CDJONNtctggc6wTvOxUwFic+iVbqTbvaAoBC KB3nbq6X07AiTK8V26/He4s3xBsIYqflj/tFIJj/fGfyVSombxek5mhh891r13CI UUCIAwa77KzWFI8+SukEkxy4+cblfVHTCK5nig7MaD104ln/Y/1NPocWVpREmfV5 64o4VaPlltgSWi7E8rsATooOASxgPMFWkwglf4WvcwFWBLrl2Z3izVzjXZmVZkzJ iXFYED3nx/Jy090W+aTktfOKWPkMsA== =m7P3 -----END PGP SIGNATURE----- --=-=-=--