From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fOqr9-0000cz-Pc
	for guix-patches@gnu.org; Fri, 01 Jun 2018 16:41:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fOqr8-0000W6-SN
	for guix-patches@gnu.org; Fri, 01 Jun 2018 16:41:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50319)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fOqr8-0000Ve-OJ
	for guix-patches@gnu.org; Fri, 01 Jun 2018 16:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fOqr8-00029o-H1
	for guix-patches@gnu.org; Fri, 01 Jun 2018 16:41:02 -0400
Subject: [bug#31399] [PATCH] import: elpa: Implement recursive import.
Resent-Message-ID: <handler.31399.B31399.15278856208233@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87y3grykhx.fsf@gmail.com> <87wovs2bdq.fsf@gnu.org>
	<87603bc31l.fsf@mdc-berlin.de> <877enmzg6d.fsf@gnu.org>
	<87efhtdruj.fsf@gmail.com>
Date: Fri, 01 Jun 2018 22:40:08 +0200
In-Reply-To: <87efhtdruj.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 30
	May 2018 19:35:16 +0300")
Message-ID: <87vab26y1j.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: Ricardo Wurmus <rekado@elephly.net>, Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, 31399@debbugs.gnu.org

Hello Oleg!

Oleg Pykhalov <go.wigust@gmail.com> skribis:

>> Oleg, could you factorize what=E2=80=99s common between the two importer=
s in
>> (guix import utils) like Ricardo suggests?
>
> OK, here is a patch:

That was fast.  :-)

> From 80015053776fb8b3aad6ae730c0e32f655536d9e Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Wed, 30 May 2018 19:08:50 +0300
> Subject: [PATCH] import: utils: Add recursive-import.
>
> * doc/guix.texi (Invoking guix import): Document elpa recursive import.
> * guix/import/cran.scm (cran-guix-name, cran-recursive-import): New
> procedures.
> (recursive-import): Remove procedure.
> * guix/import/elpa.scm (elpa-package->sexp): Return package and
> dependencies values.
> (elpa-guix-name, elpa-recursive-import): New procedures.
> * guix/import/utils.scm (guix-name, recursive-import): New procedures.
> * guix/scripts/import/cran.scm (guix-import-cran): Use
> 'cran-recursive-import' procedure.
> * guix/scripts/import/elpa.scm (show-help, %options): Add recursive
> option.
> (guix-import-elpa): Use 'elpa-recursive-import'.

Nice!

I=E2=80=99d find it clearer to have a first patch that moves code from cran=
.scm
to utils.scm, and a second patch containing the ELPA changes.  No big
deal though.

Please double-check that tests/{elpa,cran}.scm still pass, but if they
do, I think you can go ahead and push.

Thank you!

Ludo=E2=80=99.