From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/06: gnu: guile-redis: Update to 1.0.0.
Date: Fri, 24 Aug 2018 12:33:36 +0200
Message-ID: <87va80oxz3.fsf@gnu.org>
References: <20180820143226.22345.8646@vcs0.savannah.gnu.org>
	<20180820143227.CAE172052C@vcs0.savannah.gnu.org>
	<877ekhbmzl.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ft9PS-0005ku-Mz
	for guix-devel@gnu.org; Fri, 24 Aug 2018 06:33:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ft9PP-00076M-H1
	for guix-devel@gnu.org; Fri, 24 Aug 2018 06:33:42 -0400
In-Reply-To: <877ekhbmzl.fsf@netris.org> (Mark H. Weaver's message of "Thu, 23
	Aug 2018 02:44:46 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit a50eed201bf470b3bd124a2983bcea3453ec698f
>> Author: Ludovic Court=C3=A8s <ludo@gnu.org>
>> Date:   Mon Aug 20 14:35:33 2018 +0200
>>
>>     gnu: guile-redis: Update to 1.0.0.
>>=20=20=20=20=20
>>     * gnu/packages/guile.scm (guile-redis): Update to 1.0.0.
>>     [source]: Fetch from github.com.  Remove snippet.
>>     [native-inputs]: Add AUTOCONF, AUTOMAKE, and PKG-CONFIG.
>> ---
>>  gnu/packages/guile.scm | 27 ++++++++-------------------
>>  1 file changed, 8 insertions(+), 19 deletions(-)
>>
>> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
>> index f179f29..358613b 100644
>> --- a/gnu/packages/guile.scm
>> +++ b/gnu/packages/guile.scm
>> @@ -1241,31 +1241,20 @@ above command-line parameters.")
>>  (define-public guile-redis
>>    (package
>>      (name "guile-redis")
>> -    (version "0.1.0")
>> +    (version "1.0.0")
>> +    (home-page "https://github.com/aconchillo/guile-redis")
>>      (source (origin
>>                (method url-fetch)
>> -              (uri (string-append "mirror://savannah/guile-redis/guile-=
redis-"
>> -                                  version ".tar.gz"))
>> +              (uri (string-append home-page "/archive/" version ".tar.g=
z"))
>
> [...]
>
>>      (home-page "https://savannah.nongnu.org/projects/guile-redis/")
>>      (synopsis "Redis client library for Guile")
>>      (description "Guile-redis provides a Scheme interface to the Redis
>
> This commit introduced a duplicate 'home-page' field.  You made the same
> mistake in your recent commit adding 'guile-gcrypt'.  I detected these
> problems quickly because I include the "records: detect duplicate field
> initializers" commit on my private branch.

Oops!

> Anyway, in the case of 'guile-gcrypt', both of the home-page
> initializers were the same.  In the case of 'guile-redis', they are
> different.  They are:
>
>> +    (home-page "https://github.com/aconchillo/guile-redis")
> [...]
>>      (home-page "https://savannah.nongnu.org/projects/guile-redis/")
>
> Which one is correct?  I deleted the second one, because the first one
> is referenced in the source URI field, and initially I didn't notice
> that they were different.  Did guile-redis move from Savannah to GitHub?

Yes, it moved to GitHub.

Thanks for fixing these!

Ludo=E2=80=99.