all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#32739] Fix python-pyudev and solaar.
@ 2018-09-15  9:05 Roel Janssen
  2018-09-15 11:25 ` Danny Milosavljevic
  0 siblings, 1 reply; 3+ messages in thread
From: Roel Janssen @ 2018-09-15  9:05 UTC (permalink / raw)
  To: 32739

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

Dear Guix,

When installing solaar:

$ guix package -i solaar

And then running it, I get:

$ solaar
missing required package 'python-pyudev'

Now, 'python-pyudev' is already a dependency of that package, but when
loading pyudev in python, we get:

$ python3
Python 3.6.5 (default, Jan  1 1970, 00:00:01) 
[GCC 5.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyudev
...
ModuleNotFoundError: No module named 'six'

Therefore, I think 'python-pyudev' is missing a dependency for
'python-six'.

In the following patch I added this dependency to python-pyudev, after
which “import pyudev” works, and solaar starts.

Kind regards,
Roel Janssen


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-admin-python-pyudev-Add-dependency-on-python-six.patch --]
[-- Type: text/x-patch, Size: 858 bytes --]

From c14651e0b4aa1dc922fbbc79df15f2e527f8710d Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Sat, 15 Sep 2018 11:03:31 +0200
Subject: [PATCH] admin: python-pyudev: Add dependency on python-six.

* gnu/packages/admin.scm (python-pyudev): Add dependency on python-six.
---
 gnu/packages/admin.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index c6e1044b2..6949f6019 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2779,6 +2779,8 @@ support forum.  It runs with the @code{/exec} command in most IRC clients.")
                #t))))))
     (inputs
      `(("eudev" ,eudev)))
+    (propagated-inputs
+     `(("python-six" ,python-six)))
     (native-inputs
      `(("python-docutils" ,python-docutils)
        ("python-hypothesis" ,python-hypothesis)
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#32739] Fix python-pyudev and solaar.
  2018-09-15  9:05 [bug#32739] Fix python-pyudev and solaar Roel Janssen
@ 2018-09-15 11:25 ` Danny Milosavljevic
  2018-09-15 19:27   ` bug#32739: " Roel Janssen
  0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2018-09-15 11:25 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 32739

[-- Attachment #1: Type: text/plain, Size: 7 bytes --]

LGTM!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#32739: Fix python-pyudev and solaar.
  2018-09-15 11:25 ` Danny Milosavljevic
@ 2018-09-15 19:27   ` Roel Janssen
  0 siblings, 0 replies; 3+ messages in thread
From: Roel Janssen @ 2018-09-15 19:27 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 32739-done


Danny Milosavljevic <dannym@scratchpost.org> writes:

> LGTM!

Thanks for the quick review.
I've pushed the patch in cbb1b1686.

Kind regards,
Roel Janssen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-15 19:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-15  9:05 [bug#32739] Fix python-pyudev and solaar Roel Janssen
2018-09-15 11:25 ` Danny Milosavljevic
2018-09-15 19:27   ` bug#32739: " Roel Janssen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.