From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38196)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gRJnn-0001jx-HV
	for guix-patches@gnu.org; Mon, 26 Nov 2018 11:32:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gRJnm-000599-Rk
	for guix-patches@gnu.org; Mon, 26 Nov 2018 11:32:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45765)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gRJnm-00058x-O5
	for guix-patches@gnu.org; Mon, 26 Nov 2018 11:32:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gRJnm-0001KW-KP
	for guix-patches@gnu.org; Mon, 26 Nov 2018 11:32:02 -0500
Subject: bug#33514: shepherd: fix bootstrap/build from git
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.33514.D33514.15432498885046.done@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <51974da7-e8d6-7b3d-ba6b-e0c4bc4210c1@gmail.com>
Date: Mon, 26 Nov 2018 17:31:16 +0100
In-Reply-To: <51974da7-e8d6-7b3d-ba6b-e0c4bc4210c1@gmail.com> (Florian Dold's
	message of "Mon, 26 Nov 2018 15:43:16 +0100")
Message-ID: <87va4j94x7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Florian Dold <florian.dold@gmail.com>
Cc: 33514-done@debbugs.gnu.org

Hi Florian,

Florian Dold <florian.dold@gmail.com> skribis:

> the Shepherd currently does not build from a clean git repository (on
> GuixSD in a shepherd environment), as "autoreconf -ifv" does not create
> missing files related to gettext unless the version is specified.
>
> This tiny patch fixes the gettext version and allows bootstrapping to
> work from a clean git checkout.

Good catch, applied!

> By the way, shouldn't there also be a "./bootstrap" shell script, as is
> customary in a lot of projects including Guix?

FWIW I prefer to just run =E2=80=9Cautoreconf -vfi=E2=80=9D, which is what =
=E2=80=98./bootstrap=E2=80=99
does in Guix.  =E2=80=98./bootstrap=E2=80=99 scripts tend to have different=
 semantics
between projects (some run =E2=80=98./configure=E2=80=99, some don=E2=80=99=
t, etc.) so I like to
keep it simple.

Thoughts?

Thanks,
Ludo=E2=80=99.